From: Florian Fainelli <f.fainelli@gmail•com>
To: netdev@vger•kernel.org
Cc: davem@davemloft•net, pgynther@google•com, jaedon.shin@gmail•com,
vivien.didelot@savoirfairelinux•com,
jerome.oufella@savoirfairelinux•com, linux@roeck-us•net,
andrew@lunn•ch, cphealy@gmail•com, mathieu@codeaurora•org,
jonasj76@gmail•com, andrey.volkov@nexvision•fr,
Chris.Packham@alliedtelesis•co.nz, alexander.h.duyck@redhat•com
Subject: Re: [PATCH net-next 3/4] net: dsa: Refactor transmit path
Date: Thu, 30 Jul 2015 12:40:36 -0700 [thread overview]
Message-ID: <55BA7DB4.9060705@gmail.com> (raw)
In-Reply-To: <1438284939-2750-4-git-send-email-f.fainelli@gmail.com>
On 30/07/15 12:35, Florian Fainelli wrote:
> All tagging protocols do the same thing: increment device statistics,
> make room for the tag to be inserted, create the tag, invoke the parent
> network device transmit function.
>
> In order to prepare for adding netpoll support, which requires the tag
> creation, but not using the parent network device transmit function, do
> some little refactoring which eliminates duplication between the 4
> tagging protocols supported.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail•com>
> ---
[snip]
> /*
> * We have to make sure that the trailer ends up as the very
> * last 4 bytes of the packet. This means that we have to pad
> @@ -36,7 +33,7 @@ static netdev_tx_t trailer_xmit(struct sk_buff *skb, struct net_device *dev)
> nskb = alloc_skb(NET_IP_ALIGN + skb->len + padlen + 4, GFP_ATOMIC);
> if (nskb == NULL) {
> kfree_skb(skb);
> - return NETDEV_TX_OK;
> + return -ENOMEM;
I just spotted this, this won't work since we allocated a new SKB, but
the transmit code will attempt to submit skb, not nskb, I will respin
this patch series, sorry for not noticing this earlier...
David, please discard this.
--
Florian
next prev parent reply other threads:[~2015-07-30 19:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 19:35 [PATCH net-next 0/4] net: GENET, SYSTEMPORT and DSA netconsole Florian Fainelli
2015-07-30 19:35 ` [PATCH net-next 1/4] net: bcmgenet: Add netconsole support Florian Fainelli
[not found] ` <CAGXr9JECxcM3gaWh=k4g8c7mNvVyDD_1=80rg_FLXcedC0RHzQ@mail.gmail.com>
2015-07-30 22:43 ` Petri Gynther
2015-07-30 19:35 ` [PATCH net-next 2/4] net: systemport: " Florian Fainelli
2015-07-30 19:35 ` [PATCH net-next 3/4] net: dsa: Refactor transmit path Florian Fainelli
2015-07-30 19:40 ` Florian Fainelli [this message]
2015-07-30 19:35 ` [PATCH net-next 4/4] net: dsa: Add netconsole support Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BA7DB4.9060705@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=Chris.Packham@alliedtelesis$(echo .)co.nz \
--cc=alexander.h.duyck@redhat$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=andrey.volkov@nexvision$(echo .)fr \
--cc=cphealy@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jaedon.shin@gmail$(echo .)com \
--cc=jerome.oufella@savoirfairelinux$(echo .)com \
--cc=jonasj76@gmail$(echo .)com \
--cc=linux@roeck-us$(echo .)net \
--cc=mathieu@codeaurora$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pgynther@google$(echo .)com \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox