From: Alexei Starovoitov <ast@plumgrid•com>
To: Kaixu Xia <xiakaixu@huawei•com>,
davem@davemloft•net, acme@kernel•org, mingo@redhat•com,
a.p.zijlstra@chello•nl, masami.hiramatsu.pt@hitachi•com,
jolsa@kernel•org, daniel@iogearbox•net
Cc: wangnan0@huawei•com, linux-kernel@vger•kernel.org,
pi3orama@163•com, hekuang@huawei•com, netdev@vger•kernel.org
Subject: Re: [PATCH v5 2/4] bpf: Add new bpf map type to store the pointer to struct perf_event
Date: Fri, 31 Jul 2015 09:39:36 -0700 [thread overview]
Message-ID: <55BBA4C8.1030805@plumgrid.com> (raw)
In-Reply-To: <1438343970-11974-3-git-send-email-xiakaixu@huawei.com>
On 7/31/15 4:59 AM, Kaixu Xia wrote:
> + /*
> + * prevent some crazy events so we can make our life easier
> + */
> + if (event->attr.type != PERF_TYPE_RAW &&
> + event->attr.type != PERF_TYPE_HARDWARE) {
> + perf_event_release_kernel(event);
> + return ERR_PTR(-EINVAL);
> + }
either remove the comment and make it clean.
next prev parent reply other threads:[~2015-07-31 16:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 11:59 [PATCH v5 0/4] bpf: Introduce the new ability of eBPF programs to access hardware PMU counter Kaixu Xia
2015-07-31 11:59 ` [PATCH v5 1/4] bpf: Make the bpf_prog_array_map more generic Kaixu Xia
2015-07-31 16:36 ` Alexei Starovoitov
2015-07-31 11:59 ` [PATCH v5 2/4] bpf: Add new bpf map type to store the pointer to struct perf_event Kaixu Xia
2015-07-31 16:39 ` Alexei Starovoitov [this message]
2015-07-31 11:59 ` [PATCH v5 3/4] bpf: Implement function bpf_perf_event_read() that get the selected hardware PMU conuter Kaixu Xia
2015-07-31 16:43 ` Alexei Starovoitov
2015-07-31 11:59 ` [PATCH v5 4/4] samples/bpf: example of get selected PMU counter value Kaixu Xia
2015-07-31 16:33 ` [PATCH v5 0/4] bpf: Introduce the new ability of eBPF programs to access hardware PMU counter Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BBA4C8.1030805@plumgrid.com \
--to=ast@plumgrid$(echo .)com \
--cc=a.p.zijlstra@chello$(echo .)nl \
--cc=acme@kernel$(echo .)org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=hekuang@huawei$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=masami.hiramatsu.pt@hitachi$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pi3orama@163$(echo .)com \
--cc=wangnan0@huawei$(echo .)com \
--cc=xiakaixu@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox