From: Robert Shearman <rshearma@brocade•com>
To: Dan Carpenter <dan.carpenter@oracle•com>,
"David S. Miller" <davem@davemloft•net>
Cc: "Eric W. Biederman" <ebiederm@xmission•com>,
Roopa Prabhu <roopa@cumulusnetworks•com>,
Tom Herbert <tom@herbertland•com>, <netdev@vger•kernel.org>,
<kernel-janitors@vger•kernel.org>
Subject: Re: [patch] mpls: small cleanup in inet/inet6_fib_lookup_dev()
Date: Tue, 4 Aug 2015 14:53:02 +0100 [thread overview]
Message-ID: <55C0C3BE.8010007@brocade.com> (raw)
In-Reply-To: <20150804074422.GB10867@mwanda>
On 04/08/15 08:44, Dan Carpenter wrote:
> We recently changed this code from returning NULL to returning ERR_PTR.
> There are some left over NULL assignments which we can remove. We can
> preserve the error code from ip_route_output() instead of always
> returning -ENODEV. Also these functions use a mix of gotos and direct
> returns. There is no cleanup necessary so I changed the gotos to
> direct returns.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle•com>
Acked-by: Robert Shearman <rshearma@brocade•com>
next prev parent reply other threads:[~2015-08-04 13:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 7:44 [patch] mpls: small cleanup in inet/inet6_fib_lookup_dev() Dan Carpenter
2015-08-04 13:40 ` roopa
2015-08-04 13:53 ` Robert Shearman [this message]
2015-08-07 4:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C0C3BE.8010007@brocade.com \
--to=rshearma@brocade$(echo .)com \
--cc=dan.carpenter@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ebiederm@xmission$(echo .)com \
--cc=kernel-janitors@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=roopa@cumulusnetworks$(echo .)com \
--cc=tom@herbertland$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox