Subject: Re: [PATCH] r8169: Filtered data on Rx descriptor status context

From: Sergei Shtylyov <[email-masked]>
Date: Sun, 9 Aug 2015 15:41:23 +0300

Hello.

On 8/9/2015 2:57 PM, Corcodel Marian wrote:

>   We want to start evaluate an RES Receive error summary only
>   when LS (LastFrag) occurred but without FirstFrag

> Signed-off-by: Corcodel Marian <[email-masked]>

> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 8bf8c3f..0ee0107 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -7305,12 +7305,15 @@ static int rtl_rx(struct net_device *dev, struct rtl8169_private *tp, u32 budget
>   		if (status & DescOwn)
>   			break;
>
> +		if (!(status & LastFrag))
> +			break;
> +
>   		/* This barrier is needed to keep us from reading
>   		 * any other fields out of the Rx descriptor until
>   		 * we know the status of DescOwn
>   		 */
>   		dma_rmb();
> -
> +               if (!(status & FirstFrag)) {
>   		if (unlikely(status & RxRES)) {
>   			netif_info(tp, rx_err, dev, "Rx ERROR. status = %08x\n",
>   				   status);
> @@ -7323,6 +7326,7 @@ static int rtl_rx(struct net_device *dev, struct rtl8169_private *tp, u32 budget
>   				rtl_schedule_task(tp, RTL_FLAG_TASK_RESET_PENDING);
>   				dev->stats.rx_fifo_errors++;
>   			}
> +	       }

    This won't do, you should reindent the code.

MBR, Sergei