Subject: Re: [PATCH 08/10] ss: symmetrical subhandler output extension example

From: Sergei Shtylyov <[email-masked]>
Date: Mon, 10 Aug 2015 15:19:06 +0300

On 8/10/2015 2:13 AM, Matthias Tafelmeier wrote:

> This small sized patch shall convey the locations which have to be
> changed for a symmetrical output extension. Symmetrical means in this
> context all existing semantically related handlers in the diverse
> formatters (for hr and json up to now).

> Signed-off-by: Matthias Tafelmeier <[email-masked]>
> Suggested-by: Hagen Paul Pfeifer <[email-masked]>

[...]

> diff --git a/misc/ss_json_fmt.c b/misc/ss_json_fmt.c
> index f1a53cd..e80f063 100644
> --- a/misc/ss_json_fmt.c
> +++ b/misc/ss_json_fmt.c
> @@ -161,7 +161,9 @@ static void tcp_stats_json_fmt(struct tcpstat *s)
>   	if (s->rcv_rtt) {
>   		printf(",\n%s\"rcv_rtt\": %g", indent1, s->rcv_rtt);
>   	}
> -
> +	if (s->rcv_space) {
> +		printf(",\n%s\"rcv_space\": %d", indent1, s->rcv_space);
> +	}

    {} not needed. I guess you haven't run your patches thru 
scripts/checkpatch.pl?

WBR, Sergei