From: roopa <roopa@cumulusnetworks•com>
To: Robert Shearman <rshearma@brocade•com>
Cc: davem@davemloft•net, ebiederm@xmission•com, netdev@vger•kernel.org
Subject: Re: [PATCH net-next 0/3] mpls: multipath support
Date: Wed, 12 Aug 2015 19:07:18 -0700 [thread overview]
Message-ID: <55CBFBD6.50603@cumulusnetworks.com> (raw)
In-Reply-To: <55CB82A6.8070800@brocade.com>
On 8/12/15, 10:30 AM, Robert Shearman wrote:
> On 11/08/15 22:45, Roopa Prabhu wrote:
>> From: Roopa Prabhu <roopa@cumulusnetworks•com>
>>
>> This patch series adds multipath support to mpls routes.
>>
>> resembles ipv4 multipath support. The multipath route nexthop
>> selection algorithm is the same code as in ipv4 fib code.
>>
>> I understand that the multipath algorithm in ipv4 is undergoing
>> some changes and will move mpls to similar algo if applicable once
>> those get merged.
>
> Is it necessary for the mpls patch selection algorithm to closely
> resemble the ipv4 one?
No, It is not necessary. I picked that because it was already there. And
I see that ipv4 is also getting some new multipath algorithms
(https://marc.info/?l=linux-api&m=143457208315573&w=2). I wanted to move
to the new RT_MP infra if that becomes applicable in the future.
> A flow based algorithm would be much better for traffic that is
> sensitive to re-ordering (e.g TCP, L2VPN) and IMHO we should do this
> from the start for MPLS.
>
> I've also been looking at implementing this functionality. I've got a
> set of patches for this that I can send if you'd like.
Definitely. But, It seems like you can also submit incremental patches
to mine. You can replace the current algo with a hash based with your
patches.
If that does not work for you and if you want me to merge with this
series that works too.
Thanks!,
Roopa
next prev parent reply other threads:[~2015-08-13 2:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 21:45 [PATCH net-next 0/3] mpls: multipath support Roopa Prabhu
2015-08-12 17:30 ` Robert Shearman
2015-08-13 2:07 ` roopa [this message]
2015-08-13 13:46 ` Robert Shearman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CBFBD6.50603@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ebiederm@xmission$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rshearma@brocade$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox