From: Nicolas Dichtel <nicolas.dichtel@6wind•com>
To: Vincent Bernat <vincent@bernat•im>, Jiri Benc <jbenc@redhat•com>
Cc: "David S. Miller" <davem@davemloft•net>, netdev@vger•kernel.org
Subject: Re: [PATCH] veth: replace iflink by a dedicated symlink in sysfs
Date: Wed, 19 Aug 2015 18:33:14 +0200 [thread overview]
Message-ID: <55D4AFCA.7080300@6wind.com> (raw)
In-Reply-To: <8737zf8mwd.fsf@zoro.exoscale.ch>
Le 19/08/2015 14:48, Vincent Bernat a écrit :
> ❦ 19 août 2015 14:38 +0200, Jiri Benc <jbenc@redhat•com> :
>
>>> That's the main goal of this patch: advertising the peer link as
>>> IFLA_LINK attribute triggers an infinite loop in userland software when
>>> they follow iflink to discover network devices topology. iflink has
>>> always been the index of a lower device. If a sysfs symbolic link is not
>>> good enough, I can propose a new IFLA_PEER attribute instead.
>>
>> This would cause regression and break applications for those of us who
>> started relying on the netnsid feature to match interfaces across net
>> name spaces.
>
> Yes. Unfortunately.
>
>> This is tough. If you're going to do such thing, you would at least
>> need to also introduce IFLA_PEER_NETNSID.
Probably better to introduce veth netlink attribute then, something like
IFLA_VETH_PEER and keeps IFLA_LINK_NETNSID.
>
> Yes I can.
>
> In my opinion, the change of semantics of IFLA_LINK is a break of
> API. However, I can live with it since it's easy to workaround it. It
> just seemed easier to start the discussion with a patch.
>
I also don't know what is the best way to handle this. veth advertises
its peer via IFLA_LINK since 4.1, so it's too late to change it for this
release.
next prev parent reply other threads:[~2015-08-19 16:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87fv3ier4s.fsf@zoro.exoscale.ch>
2015-08-19 6:44 ` Regression in 4.1 with veth and IFLA_LINK Vincent Bernat
2015-08-19 6:44 ` [PATCH] veth: replace iflink by a dedicated symlink in sysfs Vincent Bernat
2015-08-19 11:00 ` Jiri Benc
2015-08-19 12:13 ` Vincent Bernat
2015-08-19 12:38 ` Jiri Benc
2015-08-19 12:48 ` Vincent Bernat
2015-08-19 16:33 ` Nicolas Dichtel [this message]
2015-08-20 11:53 ` Jiri Benc
2015-08-20 14:31 ` Nicolas Dichtel
2015-08-20 21:07 ` David Miller
2015-08-22 20:51 ` Vincent Bernat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D4AFCA.7080300@6wind.com \
--to=nicolas.dichtel@6wind$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jbenc@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vincent@bernat$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox