From: David Ahern <dsa@cumulusnetworks•com>
To: Nikolay Aleksandrov <razor@blackwall•org>, netdev@vger•kernel.org
Cc: shm@cumulusnetworks•com, davem@davemloft•net,
Nikolay Aleksandrov <nikolay@cumulusnetworks•com>
Subject: Re: [PATCH net-next 0/4] vrf: cleanups part 2
Date: Wed, 19 Aug 2015 10:47:10 -0700 [thread overview]
Message-ID: <55D4C11E.5000300@cumulusnetworks.com> (raw)
In-Reply-To: <1439954830-24947-1-git-send-email-razor@blackwall.org>
On 8/18/15 8:27 PM, Nikolay Aleksandrov wrote:
> From: Nikolay Aleksandrov <nikolay@cumulusnetworks•com>
>
> Hi,
> This is the next part of vrf cleanups, patch 1 drops the SLAB_PANIC when
> creating kmem cache since it's handled, patch 02 removes a slave duplicate
> check which is already done by the lower/upper code, patch 3 moves the
> ndo_add_slave code around a bit so we can drop an error label and patch 4
> drops the master device checks which are unnecessary because the ops are
> taken from the master device itself so it can't be different.
>
> Cheers,
> Nik
>
> Nikolay Aleksandrov (4):
> vrf: don't panic on cache create failure
> vrf: remove unnecessary duplicate check
> vrf: move vrf_insert_slave so we can drop a goto label
> vrf: ndo_add|del_slave drop unnecessary checks
>
> drivers/net/vrf.c | 24 ++++--------------------
> 1 file changed, 4 insertions(+), 20 deletions(-)
>
Looks good to me. Thanks, Nikolay.
Acked-by: David Ahern <dsa@cumulusnetworks•com>
next prev parent reply other threads:[~2015-08-19 17:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 3:27 [PATCH net-next 0/4] vrf: cleanups part 2 Nikolay Aleksandrov
2015-08-19 3:27 ` [PATCH net-next 1/4] vrf: don't panic on cache create failure Nikolay Aleksandrov
2015-08-19 3:27 ` [PATCH net-next 2/4] vrf: remove unnecessary duplicate check Nikolay Aleksandrov
2015-08-19 3:27 ` [PATCH net-next 3/4] vrf: move vrf_insert_slave so we can drop a goto label Nikolay Aleksandrov
2015-08-19 3:27 ` [PATCH net-next 4/4] vrf: ndo_add|del_slave drop unnecessary checks Nikolay Aleksandrov
2015-08-19 17:47 ` David Ahern [this message]
2015-08-20 20:02 ` [PATCH net-next 0/4] vrf: cleanups part 2 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D4C11E.5000300@cumulusnetworks.com \
--to=dsa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nikolay@cumulusnetworks$(echo .)com \
--cc=razor@blackwall$(echo .)org \
--cc=shm@cumulusnetworks$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox