From: YOSHIFUJI Hideaki <hideaki.yoshifuji@miraclelinux•com>
To: Jiri Benc <jbenc@redhat•com>, davem@davemloft•net
Cc: hideaki.yoshifuji@miraclelinux•com, netdev@vger•kernel.org,
Thomas Graf <tgraf@suug•ch>
Subject: Re: [PATCH v2 net-next 13/13] ipv6: route: per route IP tunnel metadata via lightweight tunnel
Date: Thu, 20 Aug 2015 11:29:06 +0900 [thread overview]
Message-ID: <55D53B72.70403@miraclelinux.com> (raw)
In-Reply-To: <20150819123151.3802e8f3@griffin>
Jiri Benc wrote:
> On Wed, 19 Aug 2015 19:27:22 +0900, YOSHIFUJI Hideaki wrote:
>>> You're right generally. But this one should be okay and I did this
>>> deliberately: the patch adding LWTUNNEL_ENCAP_ILA was merged two days
>>> ago, is in net-next only, is not used by anything in user space yet.
>>> And I think it's better to have LWTUNNEL_ENCAP_IP and
>>> LWTUNNEL_ENCAP_IP6 without anything in between.
>>
>> I do think you should have some descriptions.
>
> Sorry, I meant to put this into the description but forget to add it
> after the rebase on top of ILA (as the patchset conflicted with the ILA
> work and was developed in parallel).
>
> Are you okay with inserting LWTUNNEL_ENCAP_IP6 before
> LWTUNNEL_ENCAP_ILA? If so, I'll resend with the explanation added.
Well, I think we should always avoid adding new entries into the
middle of enums because it will make bisecting more complex or more
difficult for example even if it *seems* that we have no users yet and
the risk is not so high.
Dave?
--
Hideaki Yoshifuji <hideaki.yoshifuji@miraclelinux•com>
Technical Division, MIRACLE LINUX CORPORATION
next prev parent reply other threads:[~2015-08-20 2:29 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 10:09 [PATCH v2 net-next 00/13] lwtunnel: per route ipv6 support for vxlan Jiri Benc
2015-08-19 10:09 ` [PATCH v2 net-next 01/13] ip_tunnels: remove custom alignment and packing Jiri Benc
2015-08-19 16:20 ` Thomas Graf
2015-08-19 10:09 ` [PATCH v2 net-next 02/13] ip_tunnels: use u8/u16/u32 Jiri Benc
2015-08-19 16:21 ` Thomas Graf
2015-08-19 10:09 ` [PATCH v2 net-next 03/13] ip_tunnels: use offsetofend Jiri Benc
2015-08-19 16:25 ` Thomas Graf
2015-08-19 10:09 ` [PATCH v2 net-next 04/13] ip_tunnels: add IPv6 addresses to ip_tunnel_key Jiri Benc
2015-08-19 16:29 ` Thomas Graf
2015-08-19 18:55 ` Alexei Starovoitov
2015-08-19 10:09 ` [PATCH v2 net-next 05/13] ip_tunnels: use tos and ttl fields also for IPv6 Jiri Benc
2015-08-19 16:31 ` Thomas Graf
2015-08-19 10:09 ` [PATCH v2 net-next 06/13] route: move lwtunnel state to dst_entry Jiri Benc
2015-08-19 16:38 ` Thomas Graf
2015-08-19 10:09 ` [PATCH v2 net-next 07/13] ipv6: drop metadata dst in ip6_route_input Jiri Benc
2015-08-19 16:41 ` Thomas Graf
2015-08-19 10:09 ` [PATCH v2 net-next 08/13] ipv6: ndisc: inherit metadata dst when creating ndisc requests Jiri Benc
2015-08-19 16:47 ` Thomas Graf
2015-08-19 10:09 ` [PATCH v2 net-next 09/13] vxlan: provide access function for vxlan socket address family Jiri Benc
2015-08-19 16:49 ` Thomas Graf
2015-08-19 10:10 ` [PATCH v2 net-next 10/13] vxlan: do not shadow flags variable Jiri Benc
2015-08-19 17:52 ` Thomas Graf
2015-08-19 10:10 ` [PATCH v2 net-next 11/13] vxlan: metadata based tunneling for IPv6 Jiri Benc
2015-08-19 17:57 ` Thomas Graf
2015-08-19 19:01 ` Alexei Starovoitov
2015-08-19 10:10 ` [PATCH v2 net-next 12/13] ipv6: route: extend flow representation with tunnel key Jiri Benc
2015-08-19 18:00 ` Thomas Graf
2015-08-19 10:10 ` [PATCH v2 net-next 13/13] ipv6: route: per route IP tunnel metadata via lightweight tunnel Jiri Benc
2015-08-19 10:17 ` YOSHIFUJI Hideaki
2015-08-19 10:20 ` Jiri Benc
2015-08-19 10:27 ` YOSHIFUJI Hideaki
2015-08-19 10:31 ` Jiri Benc
2015-08-20 2:29 ` YOSHIFUJI Hideaki [this message]
2015-08-20 5:15 ` David Miller
2015-08-19 18:03 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D53B72.70403@miraclelinux.com \
--to=hideaki.yoshifuji@miraclelinux$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jbenc@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tgraf@suug$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox