From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public•gmane.org>
To: Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public•gmane.org>
Cc: "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org>,
Jelle van der Waa <jelle-oJJ1AqDjjO4@public•gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public•gmane.org
Subject: Re: Re: [PATCH] net: sun4i-emac: Claim emac sram
Date: Mon, 24 Aug 2015 11:17:43 +0200 [thread overview]
Message-ID: <55DAE137.4040306@redhat.com> (raw)
In-Reply-To: <20150824074605.GF2413@lukather>
Hi,
On 24-08-15 09:46, Maxime Ripard wrote:
> Hi Hans,
>
> On Sun, Aug 23, 2015 at 08:31:38PM +0200, Hans de Goede wrote:
>> Claim the emac sram ourselves, rather then relying on the bootloader
>> having mapped the sram to the emac controller during boot.
>>
>> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public•gmane.org>
>> ---
>> drivers/net/ethernet/allwinner/sun4i-emac.c | 13 +++++++++++--
>> 1 file changed, 11 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/allwinner/sun4i-emac.c b/drivers/net/ethernet/allwinner/sun4i-emac.c
>> index bab01c84..48ce83e 100644
>> --- a/drivers/net/ethernet/allwinner/sun4i-emac.c
>> +++ b/drivers/net/ethernet/allwinner/sun4i-emac.c
>> @@ -28,6 +28,7 @@
>> #include <linux/of_platform.h>
>> #include <linux/platform_device.h>
>> #include <linux/phy.h>
>> +#include <linux/soc/sunxi/sunxi_sram.h>
>>
>> #include "sun4i-emac.h"
>>
>> @@ -857,11 +858,17 @@ static int emac_probe(struct platform_device *pdev)
>>
>> clk_prepare_enable(db->clk);
>>
>> + ret = sunxi_sram_claim(&pdev->dev);
>> + if (ret) {
>> + dev_err(&pdev->dev, "Error couldn't map SRAM to device\n");
>> + goto out;
>
> Shouldn't you disable you clock too?
You're right, but that is a pre-existing problem, iow an unrelated issue.
I've put doing a follow-up patch for this on my todo list.
Regards,
Hans
next prev parent reply other threads:[~2015-08-24 9:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-23 18:31 [PATCH] net: sun4i-emac: Claim emac sram Hans de Goede
[not found] ` <1440354698-11144-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-08-24 7:46 ` Maxime Ripard
2015-08-24 9:17 ` Hans de Goede [this message]
[not found] ` <55DAE137.4040306-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-08-24 13:39 ` Maxime Ripard
2015-08-25 20:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DAE137.4040306@redhat.com \
--to=hdegoede-h+wxahxf7alqt0dzr+alfa@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=jelle-oJJ1AqDjjO4@public$(echo .)gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public$(echo .)gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public$(echo .)gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox