Subject: Re: [PATCH net] sctp: asconf's process should verify address parameter is in the beginning

From: Sergei Shtylyov <[email-masked]>
Date: Mon, 24 Aug 2015 15:13:03 +0300

Hello.

On 8/24/2015 1:07 PM, Xin Long wrote:

> in sctp_process_asconf(), we get address parameter from the beginning of the
> addip params. but we never check if it's really there. if the addr param is not
> there, it still can pass sctp_verify_asconf(), then to be handled by
> sctp_process_asconf(), it will not be safe.
>
> so add a code in sctp_verify_asconf() to check the address parameter is in the
> beginning, or return false to send abort.
>
> Signed-off-by: Xin Long <[email-masked]>
> ---
>   net/sctp/sm_make_chunk.c | 8 ++++++++
>   1 file changed, 8 insertions(+)

> diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
> index 0ee5ca7..a2a72d5 100644
> --- a/net/sctp/sm_make_chunk.c
> +++ b/net/sctp/sm_make_chunk.c
> @@ -3122,6 +3122,14 @@ bool sctp_verify_asconf(const struct sctp_association *asoc,
>   	union sctp_params param;
>   	bool addr_param_seen = false;
>
> +	if(addr_param_needed){

    Space needed after *if*. Please run your patches thru 
scripts/checkpatch.pl before posting.

[...]

MBR, Sergei