Subject: Re: [v2] net: phy: fixed: propagate fixed link values to struct

From: Florian Fainelli <[email-masked]>
Date: Wed, 26 Aug 2015 11:48:05 -0700

On 26/08/15 07:58, Madalin Bucur wrote:
> The fixed link values parsed from the device tree are stored in
> the struct fixed_phy member status. The struct phy_device members
> speed, duplex were not updated.

Arguably you need to start the PHY state machine for this to work
properly, but this looks fine to me.

> 
> Signed-off-by: Madalin Bucur <[email-masked]>

Reviewed-by: Florian Fainelli <[email-masked]>

> ---
> v2: always setting phy->link, thanks Stas
> 
>  drivers/net/phy/fixed_phy.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c
> index 479b93f..99d9bc1 100644
> --- a/drivers/net/phy/fixed_phy.c
> +++ b/drivers/net/phy/fixed_phy.c
> @@ -292,6 +292,15 @@ struct phy_device *fixed_phy_register(unsigned int irq,
>  		return ERR_PTR(-EINVAL);
>  	}
>  
> +	/* propagate the fixed link values to struct phy_device */
> +	phy->link = status->link;
> +	if (status->link) {
> +		phy->speed = status->speed;
> +		phy->duplex = status->duplex;
> +		phy->pause = status->pause;
> +		phy->asym_pause = status->asym_pause;
> +	}
> +
>  	of_node_get(np);
>  	phy->dev.of_node = np;
>  
> 

-- 
Florian