From: David Ahern <dsa@cumulusnetworks•com>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, Shrijeet Mukherjee <shm@cumulusnetworks•com>
Subject: Re: vrf saddr selection
Date: Sat, 29 Aug 2015 16:43:27 -0700 [thread overview]
Message-ID: <55E2439F.7040502@cumulusnetworks.com> (raw)
In-Reply-To: <20150829.164030.1189207364184023707.davem@davemloft.net>
On 8/29/15 4:40 PM, David Miller wrote:
>
> In the output path we go:
>
> struct flowi4 fl4 = {
> /* needed to match OIF rule */
> .flowi4_oif = vrf_dev->ifindex,
> .flowi4_iif = LOOPBACK_IFINDEX,
> .flowi4_tos = RT_TOS(ip4h->tos),
> .flowi4_flags = FLOWI_FLAG_ANYSRC | FLOWI_FLAG_VRFSRC,
> .daddr = ip4h->daddr,
> };
>
> if (vrf_send_v4_prep(skb, &fl4, vrf_dev))
> goto err;
>
> if (!ip4h->saddr) {
> ip4h->saddr = inet_select_addr(skb_dst(skb)->dev, 0,
> RT_SCOPE_LINK);
> }
>
> So in the case where the source address is needed, this
> inet_select_addr() call looks like useless work.
>
> The route lookup already filled in fl4.saddr for you, why don't we
> just use that?
>
We will. My intention is to remove the udp_sendmsg change and fill in
the saddr in the VRF driver. In the process a fixed version of the above
snippet is used.
David
prev parent reply other threads:[~2015-08-29 23:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-29 23:40 vrf saddr selection David Miller
2015-08-29 23:43 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E2439F.7040502@cumulusnetworks.com \
--to=dsa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shm@cumulusnetworks$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox