From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Ahmed Amamou <ahmed@gandi•net>, netdev@vger•kernel.org
Cc: William Dauchy <william@gandi•net>
Subject: Re: [PATCH RFC v2 09/21] net: rbridge: add elected dtroot
Date: Tue, 1 Sep 2015 21:18:29 +0300 [thread overview]
Message-ID: <55E5EBF5.4070100@cogentembedded.com> (raw)
In-Reply-To: <1441122196-11662-10-git-send-email-ahmed@gandi.net>
Hello.
On 09/01/2015 06:43 PM, Ahmed Amamou wrote:
> Signed-off-by: Ahmed Amamou <ahmed@gandi•net>
> ---
> net/bridge/rbr.c | 14 ++++++++++++++
> net/bridge/rbr_private.h | 2 ++
> net/bridge/rbr_rtnetlink.c | 6 ++++++
> 3 files changed, 22 insertions(+)
>
> diff --git a/net/bridge/rbr.c b/net/bridge/rbr.c
> index c554743..31e72ef 100644
> --- a/net/bridge/rbr.c
> +++ b/net/bridge/rbr.c
> @@ -69,3 +69,17 @@ void br_trill_set_enabled(struct net_bridge *br, unsigned long val)
> br_trill_stop(br);
> }
> }
> +
> +int set_treeroot(struct rbr *rbr, uint16_t treeroot)
> +{
> + if (unlikely(!VALID_NICK(treeroot))) {
> + pr_warn_ratelimited
> + ("rbr_set_treeroot: given tree root not valid\n");
> + goto set_tree_root_fail;
This seems a bit stupid. Why not *return* directly?
> + }
> + if (rbr->treeroot != treeroot)
> + rbr->treeroot = treeroot;
> + return 0;
> + set_tree_root_fail:
> + return -ENOENT;
> +}
[...]
MBR, Sergei
next prev parent reply other threads:[~2015-09-01 18:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 15:42 [PATCH RFC v2 00/21] TRILL implementation Ahmed Amamou
2015-09-01 15:42 ` [PATCH RFC v2 01/21] net: rbridge: add trill frame description Ahmed Amamou
2015-09-01 15:42 ` [PATCH RFC v2 02/21] net: rbridge: add layer 2 IS-IS Ethertype Ahmed Amamou
2015-09-01 15:42 ` [PATCH RFC v2 03/21] net: rbridge: add RBridge structure Ahmed Amamou
2015-09-01 15:42 ` [PATCH RFC v2 04/21] net: rbridge: add CONFIG_TRILL Ahmed Amamou
2015-09-01 15:43 ` [PATCH RFC v2 05/21] net: rbridge: adapt Bridge structure Ahmed Amamou
2015-09-01 15:43 ` [PATCH RFC v2 06/21] net: rbridge: enable/disable TRILL capability Ahmed Amamou
2015-09-01 15:43 ` [PATCH RFC v2 07/21] net: rbridge: add sysfs for trill_state Ahmed Amamou
2015-09-01 15:43 ` [PATCH RFC v2 08/21] net: rbridge: get Rbridge nickname from daemon Ahmed Amamou
2015-09-01 15:43 ` [PATCH RFC v2 09/21] net: rbridge: add elected dtroot Ahmed Amamou
2015-09-01 18:18 ` Sergei Shtylyov [this message]
2015-09-01 18:26 ` ahmed amamou
2015-09-01 15:43 ` [PATCH RFC v2 10/21] net: rbridge: add rbr_node management function Ahmed Amamou
2015-09-01 18:30 ` Sergei Shtylyov
2015-09-01 15:43 ` [PATCH RFC v2 11/21] net: rbridge: clean up rbr_node on rbridge stop Ahmed Amamou
2015-09-01 15:43 ` [PATCH RFC v2 12/21] net: rbridge: update node table Ahmed Amamou
2015-09-01 15:43 ` [PATCH RFC v2 13/21] net: rbridge: add basic trill frame handling function Ahmed Amamou
2015-09-01 15:43 ` [PATCH RFC v2 14/21] net: rbridge: update forwarding database Ahmed Amamou
2015-09-01 15:43 ` [PATCH RFC v2 15/21] net: rbridge: add test on trill flag before flood Ahmed Amamou
2015-09-01 15:43 ` [PATCH RFC v2 16/21] net: rbridge: add encapsulation process Ahmed Amamou
2015-09-01 15:43 ` [PATCH RFC v2 17/21] net: rbridge: add receive function Ahmed Amamou
2015-09-01 15:43 ` [PATCH RFC v2 18/21] net: rbridge: add rbr_fwd Ahmed Amamou
2015-09-01 15:43 ` [PATCH RFC v2 19/21] net: rbridge: add rbr_multidest_fwd Ahmed Amamou
2015-09-01 15:43 ` [PATCH RFC v2 20/21] net: rbridge: replace net_port rx_handler Ahmed Amamou
2015-09-01 15:43 ` [PATCH RFC v2 21/21] net: handle packet split for trill Ahmed Amamou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E5EBF5.4070100@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=ahmed@gandi$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=william@gandi$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox