From: Nicolas Dichtel <nicolas.dichtel@6wind•com>
To: Daniel Borkmann <daniel@iogearbox•net>, davem@davemloft•net
Cc: ast@plumgrid•com, netdev@vger•kernel.org
Subject: Re: [PATCH net] sock, diag: fix panic in sock_diag_put_filterinfo
Date: Wed, 2 Sep 2015 15:10:48 +0200 [thread overview]
Message-ID: <55E6F558.9090500@6wind.com> (raw)
In-Reply-To: <8824dd0b0b627c5dfdfd767e0e366e3cc8f9505a.1441193159.git.daniel@iogearbox.net>
Le 02/09/2015 14:00, Daniel Borkmann a écrit :
> diag socket's sock_diag_put_filterinfo() dumps classic BPF programs
> upon request to user space (ss -0 -b). However, native eBPF programs
> attached to sockets (SO_ATTACH_BPF) cannot be dumped with this method:
>
> Their orig_prog is always NULL. However, sock_diag_put_filterinfo()
> unconditionally tries to access its filter length resp. wants to copy
> the filter insns from there. Internal cBPF to eBPF transformations
> attached to sockets don't have this issue, as orig_prog state is kept.
>
> It's currently only used by packet sockets. If we would want to add
> native eBPF support in the future, this needs to be done through
> a different attribute than PACKET_DIAG_FILTER to not confuse possible
> user space disassemblers that work on diag data.
>
> Fixes: 89aa075832b0 ("net: sock: allow eBPF programs to be attached to sockets")
> Signed-off-by: Daniel Borkmann <daniel@iogearbox•net>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind•com>
next prev parent reply other threads:[~2015-09-02 13:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 12:00 [PATCH net] sock, diag: fix panic in sock_diag_put_filterinfo Daniel Borkmann
2015-09-02 13:10 ` Nicolas Dichtel [this message]
2015-09-02 15:03 ` Alexei Starovoitov
2015-09-02 18:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E6F558.9090500@6wind.com \
--to=nicolas.dichtel@6wind$(echo .)com \
--cc=ast@plumgrid$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox