From: David Ahern <dsa@cumulusnetworks•com>
To: Thomas Graf <tgraf@suug•ch>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH net-next] net: Support ip route get via given table
Date: Wed, 2 Sep 2015 13:50:27 -0600 [thread overview]
Message-ID: <55E75303.208@cumulusnetworks.com> (raw)
In-Reply-To: <20150902193838.GA25648@pox.localdomain>
On 9/2/15 1:38 PM, Thomas Graf wrote:
> On 09/02/15 at 01:22pm, David Ahern wrote:
>> On 9/2/15 1:12 PM, Thomas Graf wrote:
>>> On 09/02/15 at 12:03pm, David Ahern wrote:
>>>> Add support for 'ip [-6] route get table X' where the user wants to
>>>> force the FIB lookup from a given table.
>>>>
>>>> Signed-off-by: David Ahern <dsa@cumulusnetworks•com>
>>>
>>> Will you use this outside of 'ip route get' as well? If so, how? I'm
>>> asking because you propose to add the check and new behaviour to bypass
>>> the routing rules to the routing fastpath, wouldn't it be better to
>>> handle this in inet_rtm_getroute()?
>>>
>>
>> The way IPv6 code is structured it seemed more appropriate to pass in a
>> table id as part of the flow. I made IPv4 consistent with that approach.
>
> The question is: Are you planning to use the new table_id in flowi
> in the actual datapath as well? It seems entirely wrong to add
> weight to the fast path for a control plane feature.
>
No plans at the moment.
next prev parent reply other threads:[~2015-09-02 19:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 19:03 [PATCH net-next] net: Support ip route get via given table David Ahern
2015-09-02 19:12 ` Thomas Graf
2015-09-02 19:22 ` David Ahern
2015-09-02 19:38 ` Thomas Graf
2015-09-02 19:50 ` David Ahern [this message]
2015-09-03 22:40 ` David Miller
2015-09-03 23:25 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E75303.208@cumulusnetworks.com \
--to=dsa@cumulusnetworks$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tgraf@suug$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox