Subject: Re: [PATCH] device property: Don't overwrite addr when failing in device_get_mac_address

From: Jeremy Linton <[email-masked]>
Date: Fri, 4 Sep 2015 09:03:00 -0500

On 09/03/2015 05:59 PM, Julien Grall wrote:
> The function device_get_mac_address is trying different property names
> in order to get the mac address. To check the return value, the variable
> addr (which contain the buffer pass by the caller) will be re-used. This
> means that if the previous property is not found, the next property will
> be read using a NULL buffer.

Thanks for catching that! I checked the OF version to see if it has the 
same problem, but of course it doesn't because I added the logic to pass 
the buffer into the routine.

Reviewed-by: Jeremy Linton <[email-masked]>