From: roopa <roopa@cumulusnetworks•com>
To: davem@davemloft•net
Cc: mkubecek@suse•cz, Mazziesaccount@gmail•com,
hannes@stressinduktion•org, kuznet@ms2•inr.ac.ru,
jmorris@namei•org, yoshfuji@linux-ipv6•org,
netdev@vger•kernel.org, Michal Kubecek <mkubecek@suse•cz>,
Nicolas Dichtel <nicolas.dichtel@6wind•com>
Subject: Re: [PATCH net v3] ipv6: fix multipath route replace error recovery
Date: Mon, 07 Sep 2015 17:42:18 -0700 [thread overview]
Message-ID: <55EE2EEA.5040109@cumulusnetworks.com> (raw)
In-Reply-To: <1441572402-39024-1-git-send-email-roopa@cumulusnetworks.com>
On 9/6/15, 1:46 PM, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks•com>
>
> Problem:
> The ecmp route replace support for ipv6 in the kernel, deletes the
> existing ecmp route too early, ie when it installs the first nexthop.
> If there is an error in installing the subsequent nexthops, its too late
> to recover the already deleted existing route
>
> This patch fixes the problem with the following:
> a) Changes the existing multipath route add code to a two stage process:
> build rt6_infos + insert them
> ip6_route_add rt6_info creation code is moved into
> ip6_route_info_create.
> b) This ensures that all errors are caught during building rt6_infos
> and we fail early
>
The other way I have been thinking of solving the problem is to mark the
sibling routes being replaced with some state
...so they can be restored on error. Still figuring out a way to do this
in a clean and non-intrusive way.
Or maybe just save the sibling routes (rt6_infos) being replaced in a
list and re-insert them on error.
next prev parent reply other threads:[~2015-09-08 0:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-06 20:46 [PATCH net v3] ipv6: fix multipath route replace error recovery Roopa Prabhu
2015-09-07 12:37 ` Nicolas Dichtel
2015-09-08 0:14 ` roopa
2015-09-08 0:42 ` roopa [this message]
2015-09-08 9:55 ` Nicolas Dichtel
2015-09-08 13:53 ` roopa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EE2EEA.5040109@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=Mazziesaccount@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=hannes@stressinduktion$(echo .)org \
--cc=jmorris@namei$(echo .)org \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=mkubecek@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.dichtel@6wind$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox