From: Daniel Borkmann <daniel@iogearbox•net>
To: Alexei Starovoitov <ast@plumgrid•com>,
"David S. Miller" <davem@davemloft•net>
Cc: Yonghong Song <yhs@plumgrid•com>, netdev@vger•kernel.org
Subject: Re: [PATCH net] bpf: fix out of bounds access in verifier log
Date: Tue, 08 Sep 2015 23:00:25 +0200 [thread overview]
Message-ID: <55EF4C69.3010401@iogearbox.net> (raw)
In-Reply-To: <1441744801-15537-1-git-send-email-ast@plumgrid.com>
On 09/08/2015 10:40 PM, Alexei Starovoitov wrote:
> when the verifier log is enabled the print_bpf_insn() is doing
> bpf_alu_string[BPF_OP(insn->code) >> 4]
> and
> bpf_jmp_string[BPF_OP(insn->code) >> 4]
> where BPF_OP is a 4-bit instruction opcode.
> Malformed insns can cause out of bounds access.
> Fix it by sizing arrays appropriately.
>
> The bug was found by clang address sanitizer with libfuzzer.
>
> Reported-by: Yonghong Song <yhs@plumgrid•com>
> Signed-off-by: Alexei Starovoitov <ast@plumgrid•com>
Acked-by: Daniel Borkmann <daniel@iogearbox•net>
next prev parent reply other threads:[~2015-09-08 21:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 20:40 [PATCH net] bpf: fix out of bounds access in verifier log Alexei Starovoitov
2015-09-08 21:00 ` Daniel Borkmann [this message]
2015-09-09 21:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EF4C69.3010401@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=ast@plumgrid$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=yhs@plumgrid$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox