Subject: Re: [fw filter]: Broken! fw mark based tc class selection not working

From: Jamal Hadi Salim <[email-masked]>
Date: Mon, 14 Sep 2015 08:28:05 -0400

On 09/11/15 20:00, Cong Wang wrote:
> On Fri, Sep 11, 2015 at 3:24 PM, Akshat Kakkar <[email-masked]> wrote:

> Hmm, I didn't know that before either. Looks like my tp->init change
> breaks it.
>
> Could you try the following patch?
>

I would just make init() empty for this classifier (return 0?).
If someone wants to add classids ids, change() is available.
The most common (efficient) use case is what Akshat shows.
So even the check in the classify should optimize for that i.e
if (head == NULL)
     do old method
else
     ...

cheers,
jamal