From: Andrzej Hajda <a.hajda@samsung•com>
To: Derek Chickles <derek.chickles@caviumnetworks•com>,
Satanand Burla <satananda.burla@caviumnetworks•com>,
Felix Manlunas <felix.manlunas@caviumnetworks•com>,
Raghu Vatsavayi <raghu.vatsavayi@caviumnetworks•com>,
Sunil Goutham <sgoutham@cavium•com>,
Robert Richter <rric@kernel•org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung•com>,
Marek Szyprowski <m.szyprowski@samsung•com>,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH 16/31] net/cavium/liquidio: use kmemdup rather than duplicating its implementation
Date: Wed, 16 Sep 2015 12:02:24 +0200 [thread overview]
Message-ID: <55F93E30.8080101@samsung.com> (raw)
In-Reply-To: <1438934377-4922-17-git-send-email-a.hajda@samsung.com>
Ping.
Regards
Andrzej
On 08/07/2015 09:59 AM, Andrzej Hajda wrote:
> The patch was generated using fixed coccinelle semantic patch
> scripts/coccinelle/api/memdup.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung•com>
> ---
> drivers/net/ethernet/cavium/liquidio/octeon_device.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_device.c b/drivers/net/ethernet/cavium/liquidio/octeon_device.c
> index f67641a..8e23e3f 100644
> --- a/drivers/net/ethernet/cavium/liquidio/octeon_device.c
> +++ b/drivers/net/ethernet/cavium/liquidio/octeon_device.c
> @@ -602,12 +602,10 @@ int octeon_download_firmware(struct octeon_device *oct, const u8 *data,
> snprintf(oct->fw_info.liquidio_firmware_version, 32, "LIQUIDIO: %s",
> h->version);
>
> - buffer = kmalloc(size, GFP_KERNEL);
> + buffer = kmemdup(data, size, GFP_KERNEL);
> if (!buffer)
> return -ENOMEM;
>
> - memcpy(buffer, data, size);
> -
> p = buffer + sizeof(struct octeon_firmware_file_header);
>
> /* load all images */
next prev parent reply other threads:[~2015-09-16 10:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1438934377-4922-1-git-send-email-a.hajda@samsung.com>
2015-08-07 7:59 ` [PATCH 16/31] net/cavium/liquidio: use kmemdup rather than duplicating its implementation Andrzej Hajda
2015-09-16 10:02 ` Andrzej Hajda [this message]
2015-08-07 7:59 ` [PATCH 26/31] net/sched: " Andrzej Hajda
2015-08-07 10:35 ` Daniel Borkmann
2015-08-07 7:59 ` [PATCH 27/31] net/tipc: " Andrzej Hajda
2015-09-16 10:07 ` Andrzej Hajda
2015-09-17 9:58 ` Jon Maloy
2015-09-17 1:19 ` Ying Xue
2015-08-07 7:59 ` [PATCH 28/31] net/xfrm: " Andrzej Hajda
2015-08-12 10:25 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F93E30.8080101@samsung.com \
--to=a.hajda@samsung$(echo .)com \
--cc=b.zolnierkie@samsung$(echo .)com \
--cc=derek.chickles@caviumnetworks$(echo .)com \
--cc=felix.manlunas@caviumnetworks$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=raghu.vatsavayi@caviumnetworks$(echo .)com \
--cc=rric@kernel$(echo .)org \
--cc=satananda.burla@caviumnetworks$(echo .)com \
--cc=sgoutham@cavium$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox