Subject: Re: [PATCH 2/2] airo: Implement netif_carrier_on/off

From: Sergei Shtylyov <[email-masked]>
Date: Wed, 16 Sep 2015 17:30:22 +0300

Hello.

On 9/15/2015 6:18 PM, Ondrej Zary wrote:

> Add calls to netif_carrier_on and netif_carrier_off
>
> Signed-off-by: Ondrej Zary <[email-masked]>
> ---
>   drivers/net/wireless/airo.c |    6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c
> index a8f2767..629245c 100644
> --- a/drivers/net/wireless/airo.c
> +++ b/drivers/net/wireless/airo.c
[...]
> @@ -3277,7 +3278,9 @@ static void airo_handle_link(struct airo_info *ai)
>   		eth_zero_addr(wrqu.ap_addr.sa_data);
>   		wrqu.ap_addr.sa_family = ARPHRD_ETHER;
>   		wireless_send_event(ai->dev, SIOCGIWAP, &wrqu, NULL);
> -	}
> +		netif_carrier_off(ai->dev);
> +	} else
> +		netif_carrier_off(ai->dev);

    Need {} in all branches, according the the Documentation/CodingStyle.

>   }
>
>   static void airo_handle_rx(struct airo_info *ai)
[...]

MBR, Sergei