From: Nicolas Dichtel <nicolas.dichtel@6wind•com>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, herbert@gondor•apana.org.au
Subject: Re: [PATCH net 1/2] iptunnel: make rx/tx bytes counters consistent
Date: Mon, 21 Sep 2015 09:39:00 +0200 [thread overview]
Message-ID: <55FFB414.4000800@6wind.com> (raw)
In-Reply-To: <20150920.223749.1379178493985547245.davem@davemloft.net>
Le 21/09/2015 07:37, David Miller a écrit :
> From: David Miller <davem@davemloft•net>
> Date: Sun, 20 Sep 2015 22:35:13 -0700 (PDT)
>
>>> After the patch:
>>> $ ping -c1 192.168.0.121 ; ip -s l ls dev gre1
>>> PING 192.168.0.121 (192.168.0.121) 56(84) bytes of data.
>>> 64 bytes from 192.168.0.121: icmp_req=1 ttl=64 time=2.95 ms
>>>
>>> --- 192.168.0.121 ping statistics ---
>>> 1 packets transmitted, 1 received, 0% packet loss, time 0ms
>>> rtt min/avg/max/mdev = 2.955/2.955/2.955/0.000 ms
>
> BTW, when you includ PING output in a commit message like this
> it really makes things difficult.
>
> "---" denotes end of the commit as far as tools like "git am"
> are concerned.
>
> I happened to notice this time and fix up the commit messages by hand,
> but it'd be much better if it weren't left up to chance like that.
Oh ok. I will take care of that next time.
Thank you for fixing it.
Regards,
Nicolas
prev parent reply other threads:[~2015-09-21 7:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 9:47 [PATCH net 1/2] iptunnel: make rx/tx bytes counters consistent Nicolas Dichtel
2015-09-18 9:47 ` [PATCH net 2/2] ip6tunnel: " Nicolas Dichtel
2015-09-21 5:35 ` David Miller
2015-09-21 5:35 ` [PATCH net 1/2] iptunnel: " David Miller
2015-09-21 5:37 ` David Miller
2015-09-21 7:39 ` Nicolas Dichtel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FFB414.4000800@6wind.com \
--to=nicolas.dichtel@6wind$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox