From: David Ahern <dsa@cumulusnetworks•com>
To: Tom Herbert <tom@herbertland•com>
Cc: Linux Kernel Network Developers <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next 1/9] net: Remove martian_source_keep_err goto label
Date: Wed, 23 Sep 2015 10:22:58 -0600 [thread overview]
Message-ID: <5602D1E2.8020309@cumulusnetworks.com> (raw)
In-Reply-To: <CALx6S35EmX--C5c=4X1YZR7_botr3c1+CYMigonniDO8jCZkoA@mail.gmail.com>
On 9/23/15 10:19 AM, Tom Herbert wrote:
>> @@ -1782,7 +1782,7 @@ out: return err;
>> err = fib_validate_source(skb, saddr, 0, tos, 0, dev,
>> in_dev, &itag);
>> if (err < 0)
>> - goto martian_source_keep_err;
>> + goto martian_source;
>> }
>> flags |= RTCF_BROADCAST;
>> res.type = RTN_BROADCAST;
>> @@ -1858,8 +1858,6 @@ out: return err;
>> goto out;
>>
>> martian_source:
>> - err = -EINVAL;
> Just remove t=above line, no need to rename label.
>
This is a stepping stone patch. It removes the unnecessary EINVAL and
then drops one of the duplicate labels as setup for later patches. By
patch 9 all of this is gone.
next prev parent reply other threads:[~2015-09-23 16:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 15:15 [PATCH net-next 0/9 v2] net: Refactor ip_route_input_slow David Ahern
2015-09-23 15:15 ` [PATCH net-next 1/9] net: Remove martian_source_keep_err goto label David Ahern
2015-09-23 16:19 ` Tom Herbert
2015-09-23 16:22 ` David Ahern [this message]
2015-09-23 15:15 ` [PATCH net-next 2/9] net: Remove e_inval label from ip_route_input_slow David Ahern
2015-09-23 15:45 ` Alexander Duyck
2015-09-23 16:02 ` David Ahern
2015-09-23 16:31 ` Alexander Duyck
2015-09-23 17:13 ` David Ahern
2015-09-23 17:38 ` Alexander Duyck
2015-09-23 18:03 ` David Ahern
2015-09-23 18:19 ` David Miller
2015-09-23 22:26 ` Alexander Duyck
2015-09-23 18:14 ` David Miller
2015-09-23 15:15 ` [PATCH net-next 3/9] net: Remove e_nobufs " David Ahern
2015-09-23 15:15 ` [PATCH net-next 4/9] net: Move rth handling from ip_route_input_slow to helper David Ahern
2015-09-23 15:15 ` [PATCH net-next 5/9] net: Move martian_destination " David Ahern
2015-09-23 15:15 ` [PATCH net-next 6/9] net: Remove martian_source goto David Ahern
2015-09-23 15:15 ` [PATCH net-next 7/9] net: Remove martian_destination label David Ahern
2015-09-23 17:27 ` Eric Dumazet
2015-09-23 15:15 ` [PATCH net-next 8/9] net: Remove local_input label David Ahern
2015-09-23 15:15 ` [PATCH net-next 9/9] net: Remove no_route label David Ahern
2015-09-23 15:30 ` [PATCH net-next 0/9 v2] net: Refactor ip_route_input_slow Eric Dumazet
2015-09-23 16:08 ` David Ahern
2015-09-23 17:33 ` Eric Dumazet
-- strict thread matches above, loose matches on Subject: below --
2015-09-22 22:55 [PATCH net-next 0/9] " David Ahern
2015-09-22 22:55 ` [PATCH net-next 1/9] net: Remove martian_source_keep_err goto label David Ahern
2015-09-23 1:04 ` Alexander Duyck
2015-09-23 1:39 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5602D1E2.8020309@cumulusnetworks.com \
--to=dsa@cumulusnetworks$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tom@herbertland$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox