From: Jamal Hadi Salim <jhs@mojatatu•com>
To: Cong Wang <xiyou.wangcong@gmail•com>, netdev@vger•kernel.org
Cc: Akshat Kakkar <akshat.1984@gmail•com>
Subject: Re: [Patch net] net: revert "net_sched: move tp->root allocation into fw_init()"
Date: Wed, 23 Sep 2015 14:43:28 -0400 [thread overview]
Message-ID: <5602F2D0.1050608@mojatatu.com> (raw)
In-Reply-To: <1442966471-22656-1-git-send-email-xiyou.wangcong@gmail.com>
On 09/22/15 20:01, Cong Wang wrote:
> fw filter uses tp->root==NULL to check if it is the old method,
> so it doesn't need allocation at all in this case. This patch
> reverts the offending commit and adds some comments for old
> method to make it obvious.
>
> Fixes: 33f8b9ecdb15 ("net_sched: move tp->root allocation into fw_init()")
> Reported-by: Akshat Kakkar <akshat.1984@gmail•com>
> Cc: Jamal Hadi Salim <jhs@mojatatu•com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail•com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu•com>
next prev parent reply other threads:[~2015-09-23 18:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 0:01 [Patch net] net: revert "net_sched: move tp->root allocation into fw_init()" Cong Wang
2015-09-23 18:43 ` Jamal Hadi Salim [this message]
2015-09-24 21:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5602F2D0.1050608@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=akshat.1984@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox