From: Daniel Borkmann <daniel@iogearbox•net>
To: Andrzej Hajda <a.hajda@samsung•com>, linux-kernel@vger•kernel.org
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung•com>,
Marek Szyprowski <m.szyprowski@samsung•com>,
"David S. Miller" <davem@davemloft•net>,
netdev@vger•kernel.org
Subject: Re: [PATCH 17/19] tools: bpf_jit_disasm: make get_last_jit_image return unsigned
Date: Thu, 24 Sep 2015 20:53:22 +0200 [thread overview]
Message-ID: <560446A2.2020907@iogearbox.net> (raw)
In-Reply-To: <1443103227-25612-18-git-send-email-a.hajda@samsung.com>
On 09/24/2015 04:00 PM, Andrzej Hajda wrote:
> The function returns always non-negative values.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung•com>
> ---
> Hi,
>
> To avoid problems with too many mail recipients I have sent whole
> patchset only to LKML. Anyway patches have no dependencies.
>
> Regards
> Andrzej
> ---
> tools/net/bpf_jit_disasm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/net/bpf_jit_disasm.c b/tools/net/bpf_jit_disasm.c
> index 2cd3d4c..b422dbe 100644
> --- a/tools/net/bpf_jit_disasm.c
> +++ b/tools/net/bpf_jit_disasm.c
> @@ -156,7 +156,7 @@ static void put_log_buff(char *buff)
> free(buff);
> }
>
> -static int get_last_jit_image(char *haystack, size_t hlen,
> +static unsigned int get_last_jit_image(char *haystack, size_t hlen,
> uint8_t *image, size_t ilen)
I have no problem if you want to change this, but then please also
fix up the 2nd line's indentation to match the '(' as it was before.
Thanks !
> {
> char *ptr, *pptr, *tmp;
>
next prev parent reply other threads:[~2015-09-24 18:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1443103227-25612-1-git-send-email-a.hajda@samsung.com>
2015-09-24 14:00 ` [PATCH 01/19] SUNRPC: fix variable type Andrzej Hajda
[not found] ` <1443103227-25612-2-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-09-25 20:25 ` J. Bruce Fields
2015-09-24 14:00 ` [PATCH 07/19] net: hisilicon: fix handling platform_get_irq result Andrzej Hajda
2015-09-27 5:47 ` David Miller
2015-09-24 14:00 ` [PATCH 16/19] r8169: fix handling rtl_readphy result Andrzej Hajda
2015-09-27 5:48 ` David Miller
2015-09-24 14:00 ` [PATCH 17/19] tools: bpf_jit_disasm: make get_last_jit_image return unsigned Andrzej Hajda
2015-09-24 18:53 ` Daniel Borkmann [this message]
2015-09-25 6:45 ` [PATCH v2 " Andrzej Hajda
2015-09-29 5:18 ` David Miller
2015-09-24 14:00 ` [PATCH 18/19] mac80211: make ieee80211_new_mesh_header " Andrzej Hajda
2015-09-24 14:09 ` Johannes Berg
2015-09-25 6:42 ` [PATCH v2 " Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560446A2.2020907@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=a.hajda@samsung$(echo .)com \
--cc=b.zolnierkie@samsung$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox