From: David Daney <ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public•gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org>
Cc: <ddaney.cavm-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>,
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public•gmane.org>,
<pawel.moll-5wv7dgnIgG8@public•gmane.org>,
<mark.rutland-5wv7dgnIgG8@public•gmane.org>,
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public•gmane.org>,
<galak-sgV2jX0FEOL9JmXXK+q4OQ@public•gmane.org>,
<devicetree-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>,
<netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
<david.daney-YGCgFSpz5w/QT0dZR+AlfA@public•gmane.org>
Subject: Re: [PATCH] net: mdio-octeon: Add PCI driver binding.
Date: Thu, 24 Sep 2015 15:45:41 -0700 [thread overview]
Message-ID: <56047D15.9080105@caviumnetworks.com> (raw)
In-Reply-To: <20150924.151451.1059470233561232912.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
On 09/24/2015 03:14 PM, David Miller wrote:
> From: David Daney <ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public•gmane.org>
> Date: Thu, 24 Sep 2015 15:04:23 -0700
>
>> On 09/24/2015 02:52 PM, David Miller wrote:
>>> From: David Daney <ddaney.cavm-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>
>>> Date: Tue, 22 Sep 2015 17:41:36 -0700
>>>
>>>> From: David Daney <david.daney-YGCgFSpz5w/QT0dZR+AlfA@public•gmane.org>
>>>>
>>>> When the Cavium mdio-octeon devices appear in the Thunder family of
>>>> arm64 based SoCs, they show up as PCI devices. Add PCI driver
>>>> wrapping so the driver is bound in the standard PCI device scan.
>>>>
>>>> When in this form, a single PCI device may have more than a single
>>>> bus, we call this a "nexus" of buses. The standard firmware
>>>> device_for_each_child_node() iterator is used to find the individual
>>>> buses underneath the "nexus".
>>>>
>>>> Update the device tree binding documentation for the new PCI driver
>>>> binding.
>>>>
>>>> Signed-off-by: David Daney <david.daney-YGCgFSpz5w/QT0dZR+AlfA@public•gmane.org>
>>>
>>> This patch breaks the build:
>>
>> For which architecture?
>>
>> I tested it on mips and arm64. I will try x86, as I guess that is
>> where you tried your test build.
>
> x86-64.
>
>> There is, somewhat of, a method behind the madness here.
>>
>> In order to use MSI-X interrupts, we need a corresponding PCI
>> device. Now, this driver doesn't currently use interrupts, but other
>> devices in the SoC do, so they must be PCI devices.
>
> "I need this thing, which isn't needed, therefore I'm making this
> change."
>
That is not the exact argument. It is really more like this:
1) The firmware is supplying a uniform view of the devices by making
them all PCI devices. This is done because:
a) Devices that use interrupts must be PCI.
b) Uniformity is good.
2) The OF device tree nodes for PCI devices do not result in the
creation of a platform device.
3) If there is no platform device, platform device driver binding does
not occur, and the device is useless to the kernel.
So, we think it is a good change. I don't really want to argue about
the semantics of it being a "needed change".
> Sorry, that's not a good argument.
>
> ACPI nodes have names and whatnot as well.
>
> So I haven't heard a compelling argument so far.
>
> So why not just implement this cleanly and using the existing
> framework now, and then when you have a legitimate reason for making a
> major change to the probing scheme you can do it then.
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-09-24 22:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 0:41 [PATCH] net: mdio-octeon: Add PCI driver binding David Daney
[not found] ` <1442968896-30776-1-git-send-email-ddaney.cavm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-24 21:52 ` David Miller
2015-09-24 22:04 ` David Daney
[not found] ` <56047367.3060101-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2015-09-24 22:12 ` David Daney
2015-09-24 22:16 ` David Miller
2015-09-24 22:14 ` David Miller
[not found] ` <20150924.151451.1059470233561232912.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2015-09-24 22:45 ` David Daney [this message]
2015-09-24 22:50 ` David Miller
2015-09-24 22:54 ` David Daney
2015-09-24 23:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56047D15.9080105@caviumnetworks.com \
--to=ddaney-m3mlkvoiwjvv6pq1l3v1odbpr1lh4cv8@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=david.daney-YGCgFSpz5w/QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=ddaney.cavm-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public$(echo .)gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public$(echo .)gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox