From: Dave Hansen <dave@sr71•net>
To: raanan.avargil@intel•com
Cc: dave.hansen@linux•intel.com, jeffrey.t.kirsher@intel•com,
jesse.brandeburg@intel•com, shannon.nelson@intel•com,
carolyn.wyborny@intel•com, donald.c.skidmore@intel•com,
matthew.vick@intel•com, john.ronciak@intel•com,
mitch.a.williams@intel•com, intel-wired-lan@lists•osuosl.org,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH] e1000: fix e1000e_disable_aspm_locked() warning
Date: Mon, 28 Sep 2015 08:57:18 -0700 [thread overview]
Message-ID: <5609635E.6010907@sr71.net> (raw)
In-Reply-To: <20150831212641.FA5D579A@viggo.jf.intel.com>
On 08/31/2015 02:26 PM, Dave Hansen wrote:
> From: Dave Hansen <dave.hansen@linux•intel.com>
>
> I have a .config with CONFIG_PM disabled. I get the following whenever
> compiling the e1000 driver:
>
> ...net/ethernet/intel/e1000e/netdev.c:6450:13: warning: 'e1000e_disable_aspm_locked' defined but not used [-Wunused-function]
> static void e1000e_disable_aspm_locked(struct pci_dev *pdev, u16 state)
>
> Looks like we just need to move e1000e_disable_aspm_locked() to
> be underneath the CONFIG_PM #ifdef.
This patch:
[2758f9edb]: e1000e: Fix incorrect ASPM locking
established a new caller for e1000e_disable_aspm_locked() which makes my
patch useless and wrong (it breaks the compile).
I believe we should just revert my patch.
prev parent reply other threads:[~2015-09-28 15:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 21:26 [PATCH] e1000: fix e1000e_disable_aspm_locked() warning Dave Hansen
2015-09-28 15:57 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5609635E.6010907@sr71.net \
--to=dave@sr71$(echo .)net \
--cc=carolyn.wyborny@intel$(echo .)com \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=donald.c.skidmore@intel$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=john.ronciak@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=matthew.vick@intel$(echo .)com \
--cc=mitch.a.williams@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=raanan.avargil@intel$(echo .)com \
--cc=shannon.nelson@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox