From: Weidong Wang <wangweidong1@huawei•com>
To: <sony.chacko@qlogic•com>, <Dept-HSGLinuxNICDev@qlogic•com>,
David Miller <davem@davemloft•net>
Cc: <linux-kernel@vger•kernel.org>, <netdev@vger•kernel.org>,
<rui.xiang@huawei•com>, <manish.chopra@qlogic•com>
Subject: Re: [PATCH net-next v2] BNX2: fix a Null Pointer for stats_blk
Date: Tue, 29 Sep 2015 11:15:24 +0800 [thread overview]
Message-ID: <560A024C.2020303@huawei.com> (raw)
In-Reply-To: <5608E5DE.6010706@huawei.com>
On 2015/9/28 15:01, Weidong Wang wrote:
> we have two processes to do:
> P1#: ifconfig eth0 down; which will call bnx2_close, then will
> , and set Null to stats_blk
> P2#: ifconfig eth0; which will call bnx2_get_stats64, it will
> use stats_blk.
> In one case:
> --P1#-- --P2#--
> stats_blk(no null)
> bnx2_free_mem
> ->bp->stats_blk = NULL
> GET_64BIT_NET_STATS
>
> then it will cause 'NULL Pointer' Problem.
> it is as well with 'ethtool -S ethx'.
>
> Allocate the statistics block at probe time so that this problem is
> impossible
>
> Signed-off-by: Tianhong Ding <dingtianhong@huawei•com>
> ---
Sorry for that, The sob is Error. I will fixed it.
Just Ignore it.
Regards.
Weidong
next prev parent reply other threads:[~2015-09-29 3:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 12:42 [PATCH net-next] BNX2: fix a Null Pointer for stats_blk Weidong Wang
2015-09-23 22:31 ` David Miller
2015-09-24 2:00 ` Weidong Wang
2015-09-24 5:34 ` David Miller
2015-09-24 6:53 ` Weidong Wang
2015-09-28 7:01 ` [PATCH net-next v2] " Weidong Wang
2015-09-29 3:15 ` Weidong Wang [this message]
2015-09-29 3:18 ` [PATCH net-next v2 RESEND] " Weidong Wang
2015-09-30 4:10 ` David Miller
2015-10-08 10:03 ` [PATCH net-next v3] " Weidong Wang
2015-10-11 12:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560A024C.2020303@huawei.com \
--to=wangweidong1@huawei$(echo .)com \
--cc=Dept-HSGLinuxNICDev@qlogic$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=manish.chopra@qlogic$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rui.xiang@huawei$(echo .)com \
--cc=sony.chacko@qlogic$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox