From: David Ahern <dsa@cumulusnetworks•com>
To: Tom Herbert <tom@herbertland•com>,
davem@davemloft•net, netdev@vger•kernel.org
Cc: kernel-team@fb•com
Subject: Re: [PATCH net-next 4/6] xfrm: Add xfrm6 address translation function
Date: Tue, 29 Sep 2015 16:58:46 -0600 [thread overview]
Message-ID: <560B17A6.8040308@cumulusnetworks.com> (raw)
In-Reply-To: <1443565043-1287886-5-git-send-email-tom@herbertland.com>
Hi Tom:
On 9/29/15 4:17 PM, Tom Herbert wrote:
> This patch adds xfrm6_xlat_addr which is called in the data path
> to perform address translation (primarily for the receive path). Modules
> may register their own callback to perform a translation-- this
> registration is managed by xfrm6_xlat_addr_add and xfrm6_xlat_addr_del.
> xfrm6_xlat_addr allows translation of addresses for an sk_buff.
Seems like a stretch to lump this into xfrms. You have a separate genl
based config as opposed to the netlink xfrm API and you are calling the
xlat_addr function directly in ip6_rcv as opposed to via some policy
with dst_ops driven redirection. Why call this a xfrm?
next prev parent reply other threads:[~2015-09-29 22:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 22:17 [PATCH net-next 0/6] ila: Optimization to preserve value of early demux Tom Herbert
2015-09-29 22:17 ` [PATCH net-next 1/6] ila: Create net/ipv6/ila directory Tom Herbert
2015-09-29 22:17 ` [PATCH net-next 2/6] rhashtable: add function to replace an element Tom Herbert
2015-09-29 22:17 ` [PATCH net-next 3/6] netlink: add a start callback for starting a netlink dump Tom Herbert
2015-09-29 22:17 ` [PATCH net-next 4/6] xfrm: Add xfrm6 address translation function Tom Herbert
2015-09-29 22:58 ` David Ahern [this message]
2015-09-30 8:39 ` Steffen Klassert
2015-09-29 22:17 ` [PATCH net-next 5/6] ipv6: Call xfrm6_xlat_addr from ipv6_rcv Tom Herbert
2015-09-29 23:26 ` Florian Westphal
2015-09-30 9:06 ` Steffen Klassert
2015-09-30 18:40 ` Tom Herbert
2015-09-29 22:17 ` [PATCH net-next 6/6] ila: Add support for xfrm6_xlat_addr Tom Herbert
2015-09-29 22:34 ` kbuild test robot
2015-09-29 22:49 ` kbuild test robot
2015-09-29 23:18 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560B17A6.8040308@cumulusnetworks.com \
--to=dsa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=kernel-team@fb$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tom@herbertland$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox