From: Arun Parameswaran <aparames@broadcom•com>
To: Florian Fainelli <f.fainelli@gmail•com>,
Arun Parameswaran <arunp@broadcom•com>
Cc: "David S. Miller" <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"devicetree@vger•kernel.org" <devicetree@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom•com>
Subject: Re: [PATCH 4/4] net: phy: Broadcom Cygnus internal Etherent PHY driver
Date: Wed, 30 Sep 2015 14:43:05 -0700 [thread overview]
Message-ID: <560C5769.4070607@broadcom.com> (raw)
In-Reply-To: <560C5633.5080203@gmail.com>
On 15-09-30 02:37 PM, Florian Fainelli wrote:
> On 30/09/15 13:32, Arun Parameswaran wrote:
>> Add support for the Broadcom Cygnus SoCs internal PHY's.
>> The PHYs are 1000M/100M/10M capable with support for 'EEE'
>> and 'APD' (Auto Power Down).
>>
>> This driver supports the following Broadcom Cygnus SoCs:
>> - BCM583XX (BCM58300, BCM58302, BCM58303, BCM58305)
>> - BCM113XX (BCM11300, BCM11320, BCM11350, BCM11360)
>>
>> The PHY's on these SoC's require some workarounds for
>> stable operation, both during configuration time and
>> during suspend/resume. This driver handles the
>> application of the workarounds.
>>
>> Signed-off-by: Arun Parameswaran <arunp@broadcom•com>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail•com>
>
> Some suggestions if you need to respin this patch series below, sorry
> for not catching that during the internal review:
>
>> +/* Broadcom Cygnus Phy specific registers */
>> +#define MII_BCM_CORE_BASE1E 0x1E /* Core BASE1E register */
>> +#define MII_BCM_EXPB0 0xB0 /* EXPB0 register */
>> +#define MII_BCM_EXPB1 0xB1 /* EXPB1 register */
> These defines could be moved to brcmphy.h for instance, since they are
> shared between all Broadcom PHY drivers AFAICT.
Ok, Will move these and modify the corresponding PHY drivers.
Thanks,
Arun
next prev parent reply other threads:[~2015-09-30 21:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 20:32 [PATCH 0/4] Add support for Broadcom's iProc MDIO and Cygnus Ethernet PHY Arun Parameswaran
[not found] ` <1443645163-2822-1-git-send-email-arunp-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-09-30 20:32 ` [PATCH 1/4] dt-bindings: net: Broadcom iProc MDIO bus driver device tree binding Arun Parameswaran
2015-09-30 21:36 ` Florian Fainelli
[not found] ` <560C55C2.3010906-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-30 21:45 ` Arun Parameswaran
2015-09-30 20:32 ` [PATCH 2/4] net: phy: Broadcom iProc MDIO bus driver Arun Parameswaran
2015-09-30 21:36 ` Florian Fainelli
2015-09-30 20:32 ` [PATCH 3/4] net: phy: Add Broadcom phy library for common interfaces Arun Parameswaran
2015-09-30 21:13 ` kbuild test robot
2015-09-30 21:35 ` Florian Fainelli
2015-09-30 20:32 ` [PATCH 4/4] net: phy: Broadcom Cygnus internal Etherent PHY driver Arun Parameswaran
[not found] ` <1443645163-2822-5-git-send-email-arunp-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-09-30 21:37 ` Florian Fainelli
2015-09-30 21:43 ` Arun Parameswaran [this message]
2015-10-01 0:37 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560C5769.4070607@broadcom.com \
--to=aparames@broadcom$(echo .)com \
--cc=arunp@broadcom$(echo .)com \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=f.fainelli@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox