From: David Ahern <dsa@cumulusnetworks•com>
To: Cong Wang <xiyou.wangcong@gmail•com>, netdev@vger•kernel.org
Subject: Re: [Patch net-next] vrf: fix a kernel warning
Date: Thu, 1 Oct 2015 16:26:34 -0600 [thread overview]
Message-ID: <560DB31A.20500@cumulusnetworks.com> (raw)
In-Reply-To: <1443738068-30750-1-git-send-email-xiyou.wangcong@gmail.com>
On 10/1/15 4:21 PM, Cong Wang wrote:
> This fixes:
>
> tried to remove device ip6gre0 from (null)
...
>
> Fixes: 93a7e7e837af ("net: Remove the now unused vrf_ptr")
> Cc: David Ahern <dsa@cumulusnetworks•com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail•com>
> ---
> drivers/net/vrf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c
> index 64f2ab6..4743963 100644
> --- a/drivers/net/vrf.c
> +++ b/drivers/net/vrf.c
> @@ -672,7 +672,7 @@ static int vrf_device_event(struct notifier_block *unused,
> if (event == NETDEV_UNREGISTER) {
> struct net_device *vrf_dev;
>
> - if (netif_is_l3_master(dev))
> + if (!vrf_is_slave(dev) || netif_is_l3_master(dev))
> goto out;
>
> vrf_dev = netdev_master_upper_dev_get(dev);
>
Acked-by: David Ahern <dsa@cumulusnetworks•com>
Thanks for the fix.
next prev parent reply other threads:[~2015-10-01 22:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 22:21 [Patch net-next] vrf: fix a kernel warning Cong Wang
2015-10-01 22:26 ` David Ahern [this message]
2015-10-05 13:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560DB31A.20500@cumulusnetworks.com \
--to=dsa@cumulusnetworks$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox