Subject: Re: [PATCH v2 1/5] net: dsa: add missing kfree on remove

From: Neil Armstrong <[email-masked]>
Date: Sat, 3 Oct 2015 17:20:25 +0200

On 10/03/2015 04:33 PM, Sergei Shtylyov wrote:
> Hello.
> 
> On 10/3/2015 5:25 PM, Neil Armstrong wrote:
> 
>> To prevent memory leakage on unbinding, add missing kfree calls.
>>
>> Signed-off-by: Neil Armstrong <[email-masked]>
>> ---
>>   net/dsa/dsa.c | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c
>> index c59fa5d..12cec40 100644
>> --- a/net/dsa/dsa.c
>> +++ b/net/dsa/dsa.c
>> @@ -914,8 +914,10 @@ static void dsa_remove_dst(struct dsa_switch_tree *dst)
>>       for (i = 0; i < dst->pd->nr_chips; i++) {
>>           struct dsa_switch *ds = dst->ds[i];
>>
>> -        if (ds != NULL)
>> +        if (ds != NULL) {
> 
>    Didn;t scripts/checkpatch.pl complain here? just if (ds) is preferred in the networking code.
> 
> MBR, Sergei
> 
Yes,

But I considered the cosmetic changes are not the subject of this serie.

Neil