From: Neil Armstrong <narmstrong@baylibre•com>
To: Florian Fainelli <f.fainelli@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
Guenter Roeck <linux@roeck-us•net>,
vivien.didelot@savoirfairelinux•com, Andrew Lunn <andrew@lunn•ch>,
Fabian Frederick <fabf@skynet•be>,
Pavel Nakonechny <pavel.nakonechny@skitlab•ru>,
Joe Perches <joe@perches•com>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
nbd@openwrt•org, sergei.shtylyov@cogentembedded•com
Subject: Re: [PATCH v2 5/5] net: dsa: exit probe if no switch were found
Date: Tue, 6 Oct 2015 08:20:32 +0100 [thread overview]
Message-ID: <56137640.8060108@baylibre.com> (raw)
In-Reply-To: <56103A3B.4020102@gmail.com>
On 10/03/2015 09:27 PM, Florian Fainelli wrote:
> Le 03/10/2015 07:26, Neil Armstrong a écrit :
>> If no switch were found in dsa_setup_dst, return -ENODEV and
>> exit the dsa_probe cleanly.
>>
>> Tested-by: Andrew Lunn <andrew@lunn•ch>
>> Tested-by: Florian Fainelli <f.fainelli@gmail•com>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre•com>
>> ---
>
> [snip]
>
>> static int dsa_probe(struct platform_device *pdev)
>> @@ -926,9 +937,9 @@ static int dsa_probe(struct platform_device *pdev)
>>
>> platform_set_drvdata(pdev, dst);
>>
>> - dsa_setup_dst(dst, dev, &pdev->dev, pd);
>> -
>> - return 0;
>> + ret = dsa_setup_dst(dst, dev, &pdev->dev, pd);
>> + if (!ret)
>> + return 0;
>
> That logic is a little weird, I would just go with something like this:
>
> ret = dsa_setup_dst(ds, dev, &pdev->dev, pd);
> if (ret)
> goto out;
>
> return 0;
>
Yes you are right, the goto out is needed to clean up the of_probe resources.
I will send a v3 with this fixed.
Neil
prev parent reply other threads:[~2015-10-06 7:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-03 14:26 [PATCH v2 5/5] net: dsa: exit probe if no switch were found Neil Armstrong
2015-10-03 20:27 ` Florian Fainelli
2015-10-06 7:20 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56137640.8060108@baylibre.com \
--to=narmstrong@baylibre$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=fabf@skynet$(echo .)be \
--cc=joe@perches$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@roeck-us$(echo .)net \
--cc=nbd@openwrt$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pavel.nakonechny@skitlab$(echo .)ru \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox