From: Matan Barak <matanb@mellanox•com>
To: Or Gerlitz <gerlitz.or@gmail•com>,
Carol Soto <clsoto@linux•vnet.ibm.com>
Cc: Or Gerlitz <ogerlitz@mellanox•com>,
David Miller <davem@davemloft•net>,
Linux Netdev List <netdev@vger•kernel.org>,
<brking@linux•vnet.ibm.com>, "Amir Vadai" <amirv@mellanox•com>
Subject: Re: [PATCH net-next] net/mlx4_core: Test interrupts fail if not all comp vectors called request_irq
Date: Tue, 6 Oct 2015 10:28:03 +0300 [thread overview]
Message-ID: <56137803.4070308@mellanox.com> (raw)
In-Reply-To: <CAJ3xEMjjDmezm2UV2_ZiUaOyAREoH3=-m6vzH7RUePR5Jc7MVg@mail.gmail.com>
On 10/5/2015 11:12 PM, Or Gerlitz wrote:
> On Mon, Oct 5, 2015 at 6:24 PM, Carol Soto <clsoto@linux•vnet.ibm.com> wrote:
>>
>>
>> On 10/4/2015 3:03 AM, Or Gerlitz wrote:
>>>
>>> On 9/29/2015 9:38 PM, clsoto@linux•vnet.ibm.com wrote:
>>>>
>>>> From: Carol L Soto <clsoto@linux•vnet.ibm.com>
>>>>
>>>> Test interrupts fails if not all completion vectors called
>>>> request_irq. This case can happen if only mlx4_en loads and
>>>> we have more completion vectors than rx rings.
>>>
>>>
>>> good catch! is this a bug since the driver 0-day or was introduced by
>>> some recent commit? in the latercase, please add a Fixes: tag before your
>>> S.O.B note.
>>
>> Probably the issue was introduced by this one
>> Fixes: c66fa19c405a ('net/mlx4: Add EQ pool')
>
> Matan, agree to the fix and analysis? if yes, Carol, please add the
> Fixes: tag to the change-log
> and anyway respin/submit the patch against/for net not net-next
>
Yeah, we should (obviously) only check EQs which are assigned to
interrupts, so skipping unassigned EQs is a good idea.
Good catch and thanks for the fix.
Matan
> Or.
>
>>
>>>>
>>>> Signed-off-by: Carol L Soto <clsoto@linux•vnet.ibm.com>
>>>> ---
>>>> drivers/net/ethernet/mellanox/mlx4/eq.c | 4 ++++
>>>> 1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/drivers/net/ethernet/mellanox/mlx4/eq.c
>>>> b/drivers/net/ethernet/mellanox/mlx4/eq.c
>>>> index 8e81e53..c344884 100644
>>>> --- a/drivers/net/ethernet/mellanox/mlx4/eq.c
>>>> +++ b/drivers/net/ethernet/mellanox/mlx4/eq.c
>>>> @@ -1364,6 +1364,10 @@ int mlx4_test_interrupts(struct mlx4_dev *dev)
>>>> * and performing a NOP command
>>>> */
>>>> for(i = 0; !err && (i < dev->caps.num_comp_vectors); ++i) {
>>>> + /* Make sure request_irq was called */
>>>> + if (!priv->eq_table.eq[i].have_irq)
>>>> + continue;
>>>> +
>>>> /* Temporary use polling for command completions */
>>>> mlx4_cmd_use_polling(dev);
>>>
>>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to majordomo@vger•kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-10-06 7:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 20:12 [PATCH net-next] net/mlx4_core: Test interrupts fail if not all comp vectors called request_irq Or Gerlitz
2015-10-06 7:28 ` Matan Barak [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-09-29 18:38 clsoto
2015-10-04 8:03 ` Or Gerlitz
2015-10-05 15:24 ` Carol Soto
2015-10-06 6:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56137803.4070308@mellanox.com \
--to=matanb@mellanox$(echo .)com \
--cc=amirv@mellanox$(echo .)com \
--cc=brking@linux$(echo .)vnet.ibm.com \
--cc=clsoto@linux$(echo .)vnet.ibm.com \
--cc=davem@davemloft$(echo .)net \
--cc=gerlitz.or@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox