From: Matan Barak <matanb@mellanox•com>
To: Carol Soto <clsoto@linux•vnet.ibm.com>,
Or Gerlitz <gerlitz.or@gmail•com>
Cc: David Miller <davem@davemloft•net>,
Linux Netdev List <netdev@vger•kernel.org>,
Or Gerlitz <ogerlitz@mellanox•com>, <brking@linux•vnet.ibm.com>
Subject: Re: [PATCH 2/2] Do not set shared_ports when nreq > MAX_MSIX
Date: Wed, 7 Oct 2015 11:08:40 +0300 [thread overview]
Message-ID: <5614D308.4010106@mellanox.com> (raw)
In-Reply-To: <5614C8E5.8040607@mellanox.com>
On 10/7/2015 10:25 AM, Matan Barak wrote:
>
>
> On 10/7/2015 12:46 AM, Carol Soto wrote:
>>
>>
>> On 10/6/2015 4:39 PM, Or Gerlitz wrote:
>>> On Wed, Oct 7, 2015 at 12:27 AM, <clsoto@linux•vnet.ibm.com> wrote:
>>>> From: Carol L Soto <clsoto@linux•vnet.ibm.com>
>>>>
>>>> If we get MAX_MSIX interrupts would like to have each receive ring
>>>> with his own msix interrupt line.
>>> so 9293267a3e2a was only partially correct? and/or not fully optimal?
>>> please elaborate more on that in your change log.
>> just not fully optimal, with commit 9293267a3e2a if I have 64 MSIXs and
>> 2 ports I can get 8 rings for each port but then the rings will share
>> the interrupt lines. For 64 MSIXs we can have each ring with his own
>> interrupt line.
>>
>>>> Fixes: 9293267a3e2a ('net/mlx4_core: Capping number of requested
>>>> MSIXs to MAX_MSIX')
>>>> Signed-off-by: Carol L Soto <clsoto@linux•vnet.ibm.com>
>>> Carol, you didn't use net/mlx4: prefix as ask for mlx4 driver patch
>>> titles, so please repost, but before that I'd like to see an ack from
>>> Matan for this patch as well.
>> Sorry completely missed it. When Matan acks will resend it.
>
> The logic seems correct to me. When there are more nreqs than we could
> possibly support (or want to support), there’s no reason to share the
> EQs between the different ports.
> Thanks for your fix.
>
Please also clean the shared_ports variable - we don't need this anymore.
> Regards,
> Matan
>
>>>
>>> Or.
>>>
>>>> ---
>>>> drivers/net/ethernet/mellanox/mlx4/main.c | 4 +---
>>>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>>>
>>>> diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c
>>>> b/drivers/net/ethernet/mellanox/mlx4/main.c
>>>> index 006757f..f03f513 100644
>>>> --- a/drivers/net/ethernet/mellanox/mlx4/main.c
>>>> +++ b/drivers/net/ethernet/mellanox/mlx4/main.c
>>>> @@ -2673,10 +2673,8 @@ static void mlx4_enable_msi_x(struct mlx4_dev
>>>> *dev)
>>>>
>>>> nreq = min_t(int, dev->caps.num_eqs -
>>>> dev->caps.reserved_eqs,
>>>> nreq);
>>>> - if (nreq > MAX_MSIX) {
>>>> + if (nreq > MAX_MSIX)
>>>> nreq = MAX_MSIX;
>>>> - shared_ports = true;
>>>> - }
>>>>
>>>> entries = kcalloc(nreq, sizeof *entries, GFP_KERNEL);
>>>> if (!entries)
>>>> --
>>>> 1.8.3.1
>>>>
>>>> --
>>>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>>>> the body of a message to majordomo@vger•kernel.org
>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
next prev parent reply other threads:[~2015-10-07 8:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 21:27 [PATCH 1/2 net] net/mlx4_core: Test interrupts fail if not all comp vectors called request_irq clsoto
2015-10-06 21:27 ` [PATCH 2/2] Do not set shared_ports when nreq > MAX_MSIX clsoto
2015-10-06 21:39 ` Or Gerlitz
2015-10-06 21:46 ` Carol Soto
2015-10-07 7:25 ` Matan Barak
2015-10-07 8:08 ` Matan Barak [this message]
2015-10-07 14:20 ` Carol Soto
2015-10-08 11:54 ` David Miller
2015-10-08 11:49 ` Or Gerlitz
2015-10-08 11:51 ` [PATCH 1/2 net] net/mlx4_core: Test interrupts fail if not all comp vectors called request_irq Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5614D308.4010106@mellanox.com \
--to=matanb@mellanox$(echo .)com \
--cc=brking@linux$(echo .)vnet.ibm.com \
--cc=clsoto@linux$(echo .)vnet.ibm.com \
--cc=davem@davemloft$(echo .)net \
--cc=gerlitz.or@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox