From: Alexei Starovoitov <ast@plumgrid•com>
To: Daniel Borkmann <daniel@iogearbox•net>, davem@davemloft•net
Cc: edumazet@google•com, netdev@vger•kernel.org
Subject: Re: [PATCH net-next] bpf, skb_do_redirect: clear sender_cpu before xmit
Date: Wed, 7 Oct 2015 08:46:52 -0700 [thread overview]
Message-ID: <56153E6C.9050202@plumgrid.com> (raw)
In-Reply-To: <ceae3b812d3e01f73efcfdff0a7817b3c61ae24e.1444205375.git.daniel@iogearbox.net>
On 10/7/15 1:16 AM, Daniel Borkmann wrote:
> Similar to commit c29390c6dfee ("xps: must clear sender_cpu before
> forwarding"), we also need to clear the skb->sender_cpu when moving
> from RX to TX via skb_do_redirect() due to the shared location of
> napi_id (used on RX) and sender_cpu (used on TX).
>
> Fixes: 27b29f63058d ("bpf: add bpf_redirect() helper")
> Signed-off-by: Daniel Borkmann<daniel@iogearbox•net>
Acked-by: Alexei Starovoitov <ast@plumgrid•com>
with the amount of skb_sender_cpu_clear() all over the code base
I wonder whether there is a better solution to all of these.
next prev parent reply other threads:[~2015-10-07 15:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 8:16 [PATCH net-next] bpf, skb_do_redirect: clear sender_cpu before xmit Daniel Borkmann
2015-10-07 15:46 ` Alexei Starovoitov [this message]
2015-10-09 0:50 ` Devon H. O'Dell
2015-10-09 2:35 ` Alexei Starovoitov
2015-10-09 16:40 ` Devon H. O'Dell
2015-10-10 3:11 ` Alexei Starovoitov
2015-10-09 17:33 ` Daniel Borkmann
2015-10-10 3:19 ` Alexei Starovoitov
2015-10-10 4:38 ` Eric Dumazet
2015-10-10 4:55 ` Alexei Starovoitov
2015-10-10 4:56 ` Alexei Starovoitov
2015-10-10 17:12 ` Eric Dumazet
2015-11-16 18:07 ` Eric Dumazet
2015-10-08 12:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56153E6C.9050202@plumgrid.com \
--to=ast@plumgrid$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox