Subject: Re: [PATCH net-next V16 2/3] Check for vlan ethernet types for 8021.q or 802.1ad

From: Sergei Shtylyov <[email-masked]>
Date: Thu, 15 Oct 2015 17:05:14 +0300

On 10/15/2015 5:01 PM, Thomas F Herbert wrote:

    Hm, I'm seeing no sign-off on this patch.

> ---
>   include/linux/if_vlan.h | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
>
> diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
> index 67ce5bd..ac23521 100644
> --- a/include/linux/if_vlan.h
> +++ b/include/linux/if_vlan.h
> @@ -627,6 +627,22 @@ static inline netdev_features_t vlan_features_check(const struct sk_buff *skb,
>
>   	return features;
>   }
> +/**
> + * eth_type_vlan - check for valid vlan ether type.
> + * @ethertype: ether type to check
> + *
> + * Returns true if the ether type is a vlan ether type.
> + */
> +static inline bool eth_type_vlan(__be16 ethertype)
> +{
> +	switch (ethertype) {
> +	case (htons(ETH_P_8021Q)):
> +	case (htons(ETH_P_8021AD)):

    Hm, I thought you had a request to delete the outer parens already...

[...]

MBR, Sergei