Subject: Re: [PATCH] net, can, ti_hecc: add DT support for the ti,hecc controller

From: Marc Kleine-Budde <[email-masked]>
Date: Mon, 19 Oct 2015 09:31:11 +0200

On 10/19/2015 09:27 AM, Heiko Schocher wrote:
>>>   .../devicetree/bindings/net/can/ti_hecc-can.txt    | 20 ++++++++++
>>>   arch/arm/boot/dts/am3517.dtsi                      | 13 +++++++
>>>   drivers/net/can/ti_hecc.c                          | 45 +++++++++++++++++++++-
>>>   3 files changed, 76 insertions(+), 2 deletions(-)
>>>   create mode 100644 Documentation/devicetree/bindings/net/can/ti_hecc-can.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/can/ti_hecc-can.txt b/Documentation/devicetree/bindings/net/can/ti_hecc-can.txt
>>> new file mode 100644
>>> index 0000000..09fab59
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/net/can/ti_hecc-can.txt
>>> @@ -0,0 +1,20 @@
>>> +* TI HECC CAN *
>>> +
>>> +Required properties:
>>> +  - compatible: Should be "ti,hecc"
>>
>> We usually put the name of the first SoC this IP core appears in to the
>> compatible.
> 
> Ok, so "ti,am335xx-hecc" would be OK?
> @Anton: you used "am35x" ... it should be "am35xx"

The "xx" is not okay. Give precisely the first SoC Version this IP core
was implemented in.

> 
>>> +  - reg: Should contain CAN controller registers location and length
>>> +  - interrupts: Should contain IRQ line for the CAN controller
>>
>> I'm missing the description of the ti,* properties. I think they are
>> required, too. Although the code doesn't enforce it.
> 
> Ok.
> 
>>> +
>>> +Example:
>>> +
>>> +	can0: hecc@5c050000 {
>>> +		compatible = "ti,hecc";
>>> +		reg = <0x5c050000 0x4000>;
>>> +		interrupts = <24>;
>>> +		ti,hecc_scc_offset = <0>;
>>> +		ti,hecc_scc_ram_offset = <0x3000>;
>>> +		ti,hecc_ram_offset = <0x3000>;
>>> +		ti,hecc_mbx_offset = <0x2000>;
>>> +		ti,hecc_int_line = <0>;
>>> +		ti,hecc_version = <1>;
>>
>> Versioning in the OF world is done via the compatible. Are the offsets a
>> per SoC parameter? I'm not sure if it's better to put
>> the offsets into the driver.
> 
> I am unsure here too..

The devicetree people will hopefully help here.

regards,
Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |