From: Alexei Starovoitov <ast@plumgrid•com>
To: "Wangnan (F)" <wangnan0@huawei•com>,
"David S. Miller" <davem@davemloft•net>
Cc: Ingo Molnar <mingo@kernel•org>,
Peter Zijlstra <a.p.zijlstra@chello•nl>,
He Kuang <hekuang@huawei•com>, Kaixu Xia <xiakaixu@huawei•com>,
Daniel Borkmann <daniel@iogearbox•net>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH v2 net-next] bpf: fix bpf_perf_event_read() helper
Date: Wed, 21 Oct 2015 23:21:48 -0700 [thread overview]
Message-ID: <5628807C.3040305@plumgrid.com> (raw)
In-Reply-To: <562874A5.1050307@huawei.com>
On 10/21/15 10:31 PM, Wangnan (F) wrote:
>> + if ((attr->type != PERF_TYPE_RAW &&
>> + !(attr->type == PERF_TYPE_SOFTWARE &&
>> + attr->config == PERF_COUNT_SW_BPF_OUTPUT) &&
>> + attr->type != PERF_TYPE_HARDWARE) ||
>> + attr->inherit) {
>
> This 'if' statement is so complex. What about using a inline function
> instead?
hmm. don't see how inline function will help readability.
next prev parent reply other threads:[~2015-10-22 6:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 22:58 [PATCH v2 net-next] bpf: fix bpf_perf_event_read() helper Alexei Starovoitov
2015-10-22 4:49 ` Wangnan (F)
2015-10-22 5:00 ` Alexei Starovoitov
2015-10-22 5:30 ` Wangnan (F)
2015-10-22 5:31 ` Wangnan (F)
2015-10-22 6:21 ` Alexei Starovoitov [this message]
2015-10-22 7:39 ` Wangnan (F)
2015-10-22 15:51 ` Alexei Starovoitov
2015-10-22 12:30 ` Wangnan (F)
2015-10-22 12:41 ` Peter Zijlstra
2015-10-22 13:57 ` Peter Zijlstra
2015-10-22 15:53 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5628807C.3040305@plumgrid.com \
--to=ast@plumgrid$(echo .)com \
--cc=a.p.zijlstra@chello$(echo .)nl \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=hekuang@huawei$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mingo@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=wangnan0@huawei$(echo .)com \
--cc=xiakaixu@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox