Subject: Re: [PATCH V2 2/2] xen-netfront: limit vnic max_queues number to online cpus

From: Joe Jin <[email-masked]>
Date: Fri, 23 Oct 2015 17:39:32 +0800

On 10/23/2015 05:30 PM, Jan Beulich wrote:
>>>> On 23.10.15 at 11:19, <[email-masked]> wrote:
>>  
>> @@ -164,6 +166,19 @@ struct netfront_rx_info {
>>  	struct xen_netif_extra_info extras[XEN_NETIF_EXTRA_TYPE_MAX - 1];
>>  };
>>  
>> +static int xennet_set_max_queues(const char *val, struct kernel_param *kp)
>> +{
>> +	unsigned int cpus = num_online_cpus();
>> +	unsigned int max_queues = simple_strtoul(val, NULL, 10);
>> +
>> +	if (max_queues == 0 || max_queues > cpus) {
>> +		pr_err("max_queues %u is out of range [0 - %u]!\n", 
> 
> I suppose you mean "...[1 - %u]!\n" here?

Yes you are right, you catch my fault again :)

Thanks so much, will resend new later.

Regards,
Joe

> Jan

-- 
Oracle <http://www.oracle.com>
Joe Jin | Software Development Director | +8610.6106.5624
ORACLE | Linux and Virtualization
No. 24 Zhongguancun Software Park, Haidian District | 100193 Beijing