public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: roopa <roopa@cumulusnetworks•com>
To: Robert Shearman <rshearma@brocade•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org,
	"Eric W. Biederman" <ebiederm@xmission•com>
Subject: Re: [PATCH net-next 1/2] mpls: fix forwarding using v4/v6 explicit null
Date: Tue, 27 Oct 2015 18:22:42 -0700	[thread overview]
Message-ID: <56302362.2050901@cumulusnetworks.com> (raw)
In-Reply-To: <1445906256-14927-2-git-send-email-rshearma@brocade.com>

On 10/26/15, 5:37 PM, Robert Shearman wrote:
> Fill in the via address length for the predefined IPv4 and IPv6
> explicit-null label routes.
>
> Fixes: f8efb73c97e2 ("mpls: multipath route support")
> Signed-off-by: Robert Shearman <rshearma@brocade•com>
> ---
>  net/mpls/af_mpls.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
> index cc972e30355b..1c58662db4b2 100644
> --- a/net/mpls/af_mpls.c
> +++ b/net/mpls/af_mpls.c
> @@ -1345,6 +1345,7 @@ static int resize_platform_label_table(struct net *net, size_t limit)
>  		rt0->rt_protocol = RTPROT_KERNEL;
>  		rt0->rt_payload_type = MPT_IPV4;
>  		rt0->rt_nh->nh_via_table = NEIGH_LINK_TABLE;
> +		rt0->rt_nh->nh_via_alen = lo->addr_len;
>  		memcpy(rt0->rt_nh->nh_via, lo->dev_addr, lo->addr_len);
>  	}
>  	if (limit > MPLS_LABEL_IPV6NULL) {
> @@ -1356,6 +1357,7 @@ static int resize_platform_label_table(struct net *net, size_t limit)
>  		rt2->rt_protocol = RTPROT_KERNEL;
>  		rt2->rt_payload_type = MPT_IPV6;
>  		rt2->rt_nh->nh_via_table = NEIGH_LINK_TABLE;
> +		rt2->rt_nh->nh_via_alen = lo->addr_len;
>  		memcpy(rt2->rt_nh->nh_via, lo->dev_addr, lo->addr_len);
>  	}
>  
Acked-by: Roopa Prabhu <roopa@cumulusnetworks•com>

  reply	other threads:[~2015-10-28  1:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27  0:37 [PATCH net-next 0/2] mpls: mulipath improvements Robert Shearman
2015-10-27  0:37 ` [PATCH net-next 1/2] mpls: fix forwarding using v4/v6 explicit null Robert Shearman
2015-10-28  1:22   ` roopa [this message]
2015-10-27  0:37 ` [PATCH net-next 2/2] mpls: reduce memory usage of routes Robert Shearman
2015-10-28  1:39   ` roopa
2015-10-28  2:53 ` [PATCH net-next 0/2] mpls: mulipath improvements David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56302362.2050901@cumulusnetworks.com \
    --to=roopa@cumulusnetworks$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=ebiederm@xmission$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=rshearma@brocade$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox