From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Wang Nan <wangnan0@huawei•com>,
acme@kernel•org, ast@kernel•org, brendan.d.gregg@gmail•com,
jolsa@kernel•org
Cc: lizefan@huawei•com, pi3orama@163•com, davem@davemloft•net,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
Alexei Starovoitov <ast@plumgrid•com>,
Arnaldo Carvalho de Melo <acme@redhat•com>
Subject: Re: [RFC PATCH net-next 2/4] perf tools: Introduce bpf-output event
Date: Wed, 28 Oct 2015 16:13:12 +0300 [thread overview]
Message-ID: <5630C9E8.5090806@cogentembedded.com> (raw)
In-Reply-To: <1446029705-199659-3-git-send-email-wangnan0@huawei.com>
Hello.
On 10/28/2015 1:55 PM, Wang Nan wrote:
> Commit a43eec304259a6c637f4014a6d4767159b6a3aa3 (bpf: introduce
> bpf_perf_event_output() helper) add a helper to enable BPF program
You haven't run the patch thru scripts/checkpath.pl, I guess? It now
enforces the certain style of citing a commit.
> output data to perf ring buffer through a new type of perf event
> PERF_COUNT_SW_BPF_OUTPUT. This patch enable perf to create perf
> event of that type. Now perf user can use following cmdline to
> receive output data from BPF programs:
>
> # perf record -a -e evt=bpf-output/no-inherit/ \
> -e ./test_bpf_output.c/maps.bpf-output.event=evt/ ls
>
> # perf script
> perf 12927 [004] 355971.129276: 0 evt=bpf-output/no-inherit/: ffffffff811ed5f1 sys_write
> perf 12927 [004] 355971.129279: 0 evt=bpf-output/no-inherit/: ffffffff811ed5f1 sys_write
> ...
>
> Signed-off-by: Wang Nan <wangnan0@huawei•com>
> Cc: Alexei Starovoitov <ast@plumgrid•com>
> Cc: Arnaldo Carvalho de Melo <acme@redhat•com>
> Cc: Brendan Gregg <brendan.d.gregg@gmail•com>
> Cc: David S. Miller <davem@davemloft•net>
> ---
> tools/perf/util/evsel.c | 6 ++++++
> tools/perf/util/parse-events.c | 4 ++++
> tools/perf/util/parse-events.l | 1 +
> 3 files changed, 11 insertions(+)
>
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index 397fb4e..f01defb 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -224,6 +224,12 @@ struct perf_evsel *perf_evsel__new_idx(struct perf_event_attr *attr, int idx)
> if (evsel != NULL)
> perf_evsel__init(evsel, attr, idx);
>
> + if ((evsel->attr.type == PERF_TYPE_SOFTWARE) &&
> + (evsel->attr.config == PERF_COUNT_SW_BPF_OUTPUT)) {
Inner parens not necessary here.
[...]
MBR, Sergei
next prev parent reply other threads:[~2015-10-28 13:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 10:55 [RFC PATCH net-next 0/4] perf tools: Support receiving output through BPF programs Wang Nan
2015-10-28 10:55 ` [RFC PATCH net-next 1/4] perf tools: Enable pre-event inherit setting by config terms Wang Nan
2015-10-28 13:21 ` Jiri Olsa
2015-10-28 13:42 ` Arnaldo Carvalho de Melo
2015-10-28 13:44 ` Arnaldo Carvalho de Melo
2015-10-28 14:17 ` Jiri Olsa
2015-10-28 10:55 ` [RFC PATCH net-next 2/4] perf tools: Introduce bpf-output event Wang Nan
2015-10-28 13:13 ` Sergei Shtylyov [this message]
2015-10-28 10:55 ` [RFC PATCH net-next 3/4] perf data: Add u32_hex data type Wang Nan
2015-10-28 10:55 ` [RFC PATCH net-next 4/4] perf data: Support converting data from bpf_perf_event_output() Wang Nan
2015-10-28 11:03 ` [RFC PATCH net-next 0/4] perf tools: Support receiving output through BPF programs Wangnan (F)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5630C9E8.5090806@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=acme@kernel$(echo .)org \
--cc=acme@redhat$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=ast@plumgrid$(echo .)com \
--cc=brendan.d.gregg@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jolsa@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=lizefan@huawei$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pi3orama@163$(echo .)com \
--cc=wangnan0@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox