From: Marc Kleine-Budde <mkl@pengutronix•de>
To: Marek Vasut <marex@denx•de>
Cc: linux-can@vger•kernel.org,
Wolfgang Grandegger <wg@grandegger•com>,
netdev@vger•kernel.org
Subject: Re: [PATCH] can: Use correct type in sizeof() in nla_put()
Date: Fri, 30 Oct 2015 15:17:44 +0100 [thread overview]
Message-ID: <56337C08.40001@pengutronix.de> (raw)
In-Reply-To: <201510301501.28536.marex@denx.de>
[-- Attachment #1: Type: text/plain, Size: 1503 bytes --]
On 10/30/2015 03:01 PM, Marek Vasut wrote:
> On Friday, October 30, 2015 at 02:40:26 PM, Marc Kleine-Budde wrote:
>> On 10/30/2015 01:48 PM, Marek Vasut wrote:
>>> The sizeof() is invoked on an incorrect variable, likely due to some
>>> copy-paste error, and this might result in memory corruption. Fix this.
>>>
>>> Signed-off-by: Marek Vasut <marex@denx•de>
>>> Cc: Wolfgang Grandegger <wg@grandegger•com>
>>> Cc: Marc Kleine-Budde <mkl@pengutronix•de>
>>> Cc: netdev@vger•kernel.org
>>
>> Applies to can and added stable on Cc.
>
> Are you absolutelly positive this doesn't break kernel ABI please ?
>
> I am a little worried there, since the size of can_clock and can_ctrlmode
> structures differ.
struct can_clock is a u32, see [1]
struct can_ctrlmode is 2 x u32.
in libsocketcan[2] it's accessed like this:
> memcpy(res,
> RTA_DATA(can_attr[IFLA_CAN_CLOCK]),
> sizeof(struct can_clock));
I think it should be ok.
Marc
[1]
http://lxr.free-electrons.com/source/include/uapi/linux/can/netlink.h#L61
[2]
http://git.pengutronix.de/?p=tools/libsocketcan.git;a=blob;f=src/libsocketcan.c;h=c97a28cca18054c8e63326eeb5a866b79344ebe2;hb=4ea9ec7cf37a0c52f2c39a13887aaad11042ef5c#l453
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2015-10-30 14:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 12:48 [PATCH] can: Use correct type in sizeof() in nla_put() Marek Vasut
2015-10-30 13:40 ` Marc Kleine-Budde
2015-10-30 14:01 ` Marek Vasut
2015-10-30 14:17 ` Marc Kleine-Budde [this message]
2015-10-30 14:24 ` Marek Vasut
2015-10-30 14:53 ` Oliver Hartkopp
2015-10-30 15:33 ` Marek Vasut
-- strict thread matches above, loose matches on Subject: below --
2015-10-30 13:39 pull-request: can 2015-10-30 Marc Kleine-Budde
2015-10-30 13:39 ` [PATCH] can: Use correct type in sizeof() in nla_put() Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56337C08.40001@pengutronix.de \
--to=mkl@pengutronix$(echo .)de \
--cc=linux-can@vger$(echo .)kernel.org \
--cc=marex@denx$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=wg@grandegger$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox