Subject: Re: [net-next PATCH] RDS: convert bind hash table to re-sizable hashtable

From: santosh shilimkar <[email-masked]>
Date: Fri, 30 Oct 2015 08:50:14 -0700

On 10/30/2015 4:15 AM, David Miller wrote:
> From: Santosh Shilimkar <[email-masked]>
> Date: Wed, 28 Oct 2015 15:51:12 -0700
>
>> +					    &rs->rs_bound_node, ht_parms)) {
>>   			*port = rs->rs_bound_port;
>>   			ret = 0;
>>   			rdsdebug("rs %p binding to %pI4:%d\n",
>>   			  rs, &addr, (int)ntohs(*port));
>>   			break;
>>   		} else {
>> -			rds_sock_put(rrs);
>> +			rds_sock_put(rs);
>> +			ret = -ENOMEM;
>> +			break;
>>   		}
>> +
>>   	} while (rover++ != last);
>>
>>   	return ret;
>
> This final insert of an empty line is both inappropriate and even
> if it was it would not be related to this change.
>
Right. I just posted v2, dropping the empty line. Thanks !!

Regards,
Santosh