Subject: Re: [PATCH] sh_eth: move inline functions to the header file

From: Sergei Shtylyov <[email-masked]>
Date: Sat, 31 Oct 2015 02:09:15 +0300

Hello.

On 04/07/2015 10:33 PM, David Miller wrote:

>>>> The explicitly inline functions belong to the header files, so move
>>>> cpu_to_edmac() and edmac_to_cpu() into the driver header.
>>
>>>> While at it, make these functions return 'u32' instead of '__u32'.
>>
>>>> Signed-off-by: Sergei Shtylyov <[email-masked]>
>>
>>> Then... ummm... remove the inline keyword?
>>
>>> If it's not used anywhere else, that's the thing to do.
>>
>>     Results in more code, as I noted in the patch posting that you skipped
>>     when replying. At least with gcc 4.7.
>
> That's a compiler bug.

    Even worse, these functions support the BE mode which never was used and 
never worked correctly. I'll just try to remove them altogether.

MBR, Sergei