Subject: Re: [PATCH net-next] net/core: ensure features get disabled on new lower devs

From: Nikolay Aleksandrov <[email-masked]>
Date: Tue, 3 Nov 2015 22:21:50 +0100

On 11/03/2015 09:36 PM, Jarod Wilson wrote:
> With moving netdev_sync_lower_features() after the .ndo_set_features
> calls, I neglected to verify that devices added *after* a flag had been
> disabled on an upper device were properly added with that flag disabled as
> well. This currently happens, because we exit __netdev_update_features()
> when we see dev->features == features for the upper dev. We can retain the
> optimization of leaving without calling .ndo_set_features with a bit of
> tweaking and a goto here.
> 
> Changing err to ret was somewhat arbitrary and makes the patch look more
> involved, but seems to better fit the altered use.
> 
> Fixes: fd867d51f ("net/core: generic support for disabling netdev features down stack")
> CC: "David S. Miller" <[email-masked]>
> CC: Eric Dumazet <[email-masked]>
> CC: Jay Vosburgh <[email-masked]>
> CC: Veaceslav Falico <[email-masked]>
> CC: Andy Gospodarek <[email-masked]>
> CC: Jiri Pirko <[email-masked]>
> CC: Nikolay Aleksandrov <[email-masked]>
> CC: Michal Kubecek <[email-masked]>
> CC: Alexander Duyck <[email-masked]>
> CC: [email-masked]
> Signed-off-by: Jarod Wilson <[email-masked]>
> ---
>  net/core/dev.c | 21 ++++++++++++---------
>  1 file changed, 12 insertions(+), 9 deletions(-)
> 

Thanks for the quick response,

Reported-by: Nikolay Aleksandrov <[email-masked]>
Tested-by: Nikolay Aleksandrov <[email-masked]>
Acked-by: Nikolay Aleksandrov <[email-masked]>
Fixes: fd867d51f889 ("net/core: generic support for disabling netdev features down stack")