Subject: Re: [PATCH net] net: fix feature changes on devices without ndo_set_features

From: Jarod Wilson <[email-masked]>
Date: Fri, 13 Nov 2015 09:34:28 -0500

Nikolay Aleksandrov wrote:
> From: Nikolay Aleksandrov<[email-masked]>
>
> When __netdev_update_features() was updated to ensure some features are
> disabled on new lower devices, an error was introduced for devices which
> don't have the ndo_set_features() method set. Before we'll just set the
> new features, but now we return an error and don't set them. Fix this by
> returning the old behaviour and setting err to 0 when ndo_set_features
> is not present.
>
> Fixes: e7868a85e1b2 ("net/core: ensure features get disabled on new lower devs")
> CC: Jarod Wilson<[email-masked]>
> CC: Jiri Pirko<[email-masked]>
> CC: Ido Schimmel<[email-masked]>
> CC: Sander Eikelenboom<[email-masked]>
> CC: Andy Gospodarek<[email-masked]>
> CC: Florian Fainelli<[email-masked]>
> Signed-off-by: Nikolay Aleksandrov<[email-masked]>
> ---
> Sander please feel free to give your Tested-by.

Ah, good catch, thank you for cleaning up my mess.

Reviewed-by: Jarod Wilson <[email-masked]>

-- 
Jarod Wilson
[email-masked]