From: Arthur Marsh <arthur.marsh@internode•on.net>
To: Jarod Wilson <jarod@redhat•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jay Vosburgh <j.vosburgh@gmail•com>,
Veaceslav Falico <vfalico@gmail•com>,
Andy Gospodarek <gospo@cumulusnetworks•com>,
Jiri Pirko <jiri@resnulli•us>,
Nikolay Aleksandrov <razor@blackwall•org>,
Michal Kubecek <mkubecek@suse•cz>,
Alexander Duyck <alexander.duyck@gmail•com>,
Linux Networking Developer Mailing List <netdev@vger•kernel.org>
Subject: Re: eth0: set_features() failed (-1); wanted 0x0000000000004000, left 0x0000000000004800
Date: Sat, 14 Nov 2015 14:24:25 +1030 [thread overview]
Message-ID: <5646B071.6020100@internode.on.net> (raw)
In-Reply-To: <5646A7A4.2070808@internode.on.net>
Arthur Marsh wrote on 14/11/15 13:46:
> Hi, I'm not sure if this is an actual error or just an informational
> message but on this pc (with a single-core AMD Athlon(tm) 64 Processor
> 3200+) I've been getting the following:
>
>
> Nov 13 18:16:12 localhost kernel: [ 0.938025] via-rhine 0000:00:12.0
> eth0: set_features() failed (-1); wanted 0x0000000000004000, left
> 0x0000000000004800
> Nov 13 18:16:12 localhost kernel: [ 0.938574] via-rhine 0000:00:12.0
> eth0: VIA Rhine II at 0x1e000, 00:13:d4:cc:9b:57, IRQ 23
> Nov 13 18:16:12 localhost kernel: [ 0.939418] via-rhine 0000:00:12.0
> eth0: MII PHY found at address 1, status 0x786d advertising 01e1 Link 45e1
>
> The Ethernet card still works nonetheless.
>
> git-bisect showed that the:
>
> eth0: set_features() failed (-1); wanted 0x0000000000004000, left
> 0x0000000000004800
>
> messages started with the following commit:
>
> git bisect good
> e7868a85e1b26bcb2e71088841eec1d310a97ac9 is the first bad commit
> commit e7868a85e1b26bcb2e71088841eec1d310a97ac9
> Author: Jarod Wilson <jarod@redhat•com>
> Date: Tue Nov 3 23:09:32 2015 -0500
>
> net/core: ensure features get disabled on new lower devs
>
> With moving netdev_sync_lower_features() after the .ndo_set_features
> calls, I neglected to verify that devices added *after* a flag had
> been
> disabled on an upper device were properly added with that flag
> disabled as
> well. This currently happens, because we exit
> __netdev_update_features()
> when we see dev->features == features for the upper dev. We can
> retain the
> optimization of leaving without calling .ndo_set_features with a
> bit of
> tweaking and a goto here.
Nikolay Aleksandrov's patch:
http://patchwork.ozlabs.org/patch/544307/
fixed the issue for me thanks.
Arthur.
prev parent reply other threads:[~2015-11-14 3:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-14 3:16 eth0: set_features() failed (-1); wanted 0x0000000000004000, left 0x0000000000004800 Arthur Marsh
2015-11-14 3:54 ` Arthur Marsh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5646B071.6020100@internode.on.net \
--to=arthur.marsh@internode$(echo .)on.net \
--cc=alexander.duyck@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gospo@cumulusnetworks$(echo .)com \
--cc=j.vosburgh@gmail$(echo .)com \
--cc=jarod@redhat$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=mkubecek@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=razor@blackwall$(echo .)org \
--cc=vfalico@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox