From: Salil Mehta <salil.mehta@huawei•com>
To: David Miller <davem@davemloft•net>
Cc: <robh+dt@kernel•org>, <pawel.moll@arm•com>,
<mark.rutland@arm•com>, <paul.gortmaker@windriver•com>,
<ijc+devicetree@hellion•org.uk>, <galak@codeaurora•org>,
<catalin.marinas@arm•com>, <will.deacon@arm•com>, <arnd@arndb•de>,
<liguozhu@hisilicon•com>, <yisen.zhuang@huawei•com>,
<dingtianhong@huawei•com>, <zhangfei.gao@linaro•org>,
<huangdaode@hisilicon•com>, <kenneth-lee-2012@foxmail•com>,
<mehta.salil.lnk@gmail•com>, <xuwei5@hisilicon•com>,
<lisheng011@huawei•com>, <devicetree@vger•kernel.org>,
<linux-kernel@vger•kernel.org>,
<linux-arm-kernel@lists•infradead.org>, <netdev@vger•kernel.org>,
<linuxarm@huawei•com>, <yankejian@huawei•com>,
<lipeng321@huawei•com>, <fengguang.wu@intel•com>
Subject: Re: [PATCH V2 net-next 1/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem
Date: Fri, 20 Nov 2015 14:15:09 +0000 [thread overview]
Message-ID: <564F2AED.30906@huawei.com> (raw)
In-Reply-To: <20151118.135250.2066223916643044258.davem@davemloft.net>
On 11/18/2015 6:52 PM, David Miller wrote:
> From: Salil <salil.mehta@huawei•com>
> Date: Wed, 18 Nov 2015 02:52:23 +0800
>
>> @@ -387,19 +409,23 @@ static void hns_rcb_ring_get_cfg(struct hnae_queue *q, int ring_type)
>> struct rcb_common_cb *rcb_common;
>> struct ring_pair_cb *ring_pair_cb;
>> u32 buf_size;
>> - u16 desc_num;
>> - int irq_idx;
>> + u16 desc_num, mdnum_ppkt;
>> + int irq_idx, is_ver1;
> Please use "bool" and true/false for boolean conditions like is_ver1.
>
> Please audit your entire submission for this problem.
Thanks for your time and comments. As per your suggestions, I have
changed the data type of variable "is_ver" to "bool" where ever possible
in the PATCH V3 floated yesterday.
Best Regards
Salil
next prev parent reply other threads:[~2015-11-20 14:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 18:52 [PATCH V2 net-next 0/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem Salil
2015-11-17 18:52 ` [PATCH V2 net-next 1/5] " Salil
[not found] ` <1447786347-147518-2-git-send-email-salil.mehta-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-11-18 18:52 ` David Miller
2015-11-20 14:15 ` Salil Mehta [this message]
2015-11-17 18:52 ` [PATCH V2 net-next 2/5] net:hns: Add Hip06 "RSS(Receive Side Scaling)" support to HNS Driver Salil
2015-11-17 18:52 ` [PATCH V2 net-next 3/5] net:hns: Add Hip06 "TSO(TCP Segment Offload)" support " Salil
2015-11-17 18:52 ` [PATCH V2 net-next 4/5] net:hns: Add support of ethtool TSO set option for Hip06 in HNS Salil
2015-11-17 18:52 ` [PATCH V2 net-next 5/5] net:hns: Add the init code to disable Hip06 "Hardware VLAN assist" Salil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564F2AED.30906@huawei.com \
--to=salil.mehta@huawei$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=catalin.marinas@arm$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dingtianhong@huawei$(echo .)com \
--cc=fengguang.wu@intel$(echo .)com \
--cc=galak@codeaurora$(echo .)org \
--cc=huangdaode@hisilicon$(echo .)com \
--cc=ijc+devicetree@hellion$(echo .)org.uk \
--cc=kenneth-lee-2012@foxmail$(echo .)com \
--cc=liguozhu@hisilicon$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxarm@huawei$(echo .)com \
--cc=lipeng321@huawei$(echo .)com \
--cc=lisheng011@huawei$(echo .)com \
--cc=mark.rutland@arm$(echo .)com \
--cc=mehta.salil.lnk@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paul.gortmaker@windriver$(echo .)com \
--cc=pawel.moll@arm$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=will.deacon@arm$(echo .)com \
--cc=xuwei5@hisilicon$(echo .)com \
--cc=yankejian@huawei$(echo .)com \
--cc=yisen.zhuang@huawei$(echo .)com \
--cc=zhangfei.gao@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox